Add names to all PageActionIconView-derived classes.

With all of the new identity and animation stuff in the toolbar, it's
important to know which button view just barfed all over any given test.

Bug: 1038567
Change-Id: Ia7832558a87cb29bedbfff0e5ece8794f2b8a8c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986227Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Auto-Submit: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728084}

chrome/browser/ui/views/autofill/payments/local_card_migration_icon_view.cc

@@ -140,6 +140,10 @@ const gfx::VectorIcon& LocalCardMigrationIconView::GetVectorIconBadge() const {
   return gfx::kNoneIcon;
 }
 
+const char* LocalCardMigrationIconView::GetClassName() const {
+  return "LocalCardMigrationIconView";
+}
+
 base::string16 LocalCardMigrationIconView::GetTextForTooltipAndAccessibleName()
     const {
   return l10n_util::GetStringUTF16(IDS_TOOLTIP_MIGRATE_LOCAL_CARD);

chrome/browser/ui/views/autofill/payments/local_card_migration_icon_view.h

@@ -34,6 +34,7 @@ class LocalCardMigrationIconView : public PageActionIconView {
   void OnExecuting(PageActionIconView::ExecuteSource execute_source) override;
   const gfx::VectorIcon& GetVectorIcon() const override;
   const gfx::VectorIcon& GetVectorIconBadge() const override;
+  const char* GetClassName() const override;
 
  private:
   ManageMigrationUiController* GetController() const;

chrome/browser/ui/views/autofill/payments/save_card_icon_view.cc

@@ -86,6 +86,10 @@ const gfx::VectorIcon& SaveCardIconView::GetVectorIconBadge() const {
   return gfx::kNoneIcon;
 }
 
+const char* SaveCardIconView::GetClassName() const {
+  return "SaveCardIconView";
+}
+
 base::string16 SaveCardIconView::GetTextForTooltipAndAccessibleName() const {
   SaveCardBubbleController* controller = GetController();
   if (!controller) {

chrome/browser/ui/views/autofill/payments/save_card_icon_view.h

@@ -34,6 +34,7 @@ class SaveCardIconView : public PageActionIconView {
   void OnExecuting(PageActionIconView::ExecuteSource execute_source) override;
   const gfx::VectorIcon& GetVectorIcon() const override;
   const gfx::VectorIcon& GetVectorIconBadge() const override;
+  const char* GetClassName() const override;
 
  private:
   SaveCardBubbleController* GetController() const;

chrome/browser/ui/views/location_bar/cookie_controls_icon_view.cc

@@ -109,6 +109,10 @@ const gfx::VectorIcon& CookieControlsIconView::GetVectorIcon() const {
   return kEyeCrossedIcon;
 }
 
+const char* CookieControlsIconView::GetClassName() const {
+  return "CookieControlsIconView";
+}
+
 base::string16 CookieControlsIconView::GetTextForTooltipAndAccessibleName()
     const {
   return l10n_util::GetStringUTF16(IDS_COOKIE_CONTROLS_TOOLTIP);

chrome/browser/ui/views/location_bar/cookie_controls_icon_view.h

@@ -35,6 +35,7 @@ class CookieControlsIconView : public PageActionIconView,
  protected:
   void OnExecuting(PageActionIconView::ExecuteSource source) override;
   const gfx::VectorIcon& GetVectorIcon() const override;
+  const char* GetClassName() const override;
 
  private:
   bool HasAssociatedBubble() const;

chrome/browser/ui/views/location_bar/find_bar_icon.cc

@@ -45,6 +45,10 @@ base::string16 FindBarIcon::GetTextForTooltipAndAccessibleName() const {
   return l10n_util::GetStringUTF16(IDS_TOOLTIP_FIND);
 }
 
+const char* FindBarIcon::GetClassName() const {
+  return "FindBarIcon";
+}
+
 void FindBarIcon::OnExecuting(ExecuteSource execute_source) {}
 
 views::BubbleDialogDelegateView* FindBarIcon::GetBubble() const {

chrome/browser/ui/views/location_bar/find_bar_icon.h

@@ -27,6 +27,7 @@ class FindBarIcon : public PageActionIconView {
   views::BubbleDialogDelegateView* GetBubble() const override;
   const gfx::VectorIcon& GetVectorIcon() const override;
   base::string16 GetTextForTooltipAndAccessibleName() const override;
+  const char* GetClassName() const override;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(FindBarIcon);

chrome/browser/ui/views/location_bar/intent_picker_view.cc

@@ -107,3 +107,7 @@ const gfx::VectorIcon& IntentPickerView::GetVectorIcon() const {
 base::string16 IntentPickerView::GetTextForTooltipAndAccessibleName() const {
   return l10n_util::GetStringUTF16(IDS_TOOLTIP_INTENT_PICKER_ICON);
 }
+
+const char* IntentPickerView::GetClassName() const {
+  return "IntentPickerView";
+}

chrome/browser/ui/views/location_bar/intent_picker_view.h

@@ -26,6 +26,7 @@ class IntentPickerView : public PageActionIconView {
   views::BubbleDialogDelegateView* GetBubble() const override;
   const gfx::VectorIcon& GetVectorIcon() const override;
   base::string16 GetTextForTooltipAndAccessibleName() const override;
+  const char* GetClassName() const override;
 
  private:
   bool IsIncognitoMode() const;

chrome/browser/ui/views/location_bar/star_view.cc

@@ -128,6 +128,10 @@ base::string16 StarView::GetTextForTooltipAndAccessibleName() const {
                                             : IDS_TOOLTIP_STAR);
 }
 
+const char* StarView::GetClassName() const {
+  return "StarView";
+}
+
 SkColor StarView::GetInkDropBaseColor() const {
   return bookmark_promo_observer_.IsObservingSources()
              ? GetNativeTheme()->GetSystemColor(

chrome/browser/ui/views/location_bar/star_view.h

@@ -40,6 +40,7 @@ class StarView : public PageActionIconView,
   SkColor GetInkDropBaseColor() const override;
   const gfx::VectorIcon& GetVectorIcon() const override;
   base::string16 GetTextForTooltipAndAccessibleName() const override;
+  const char* GetClassName() const override;
 
   // views::WidgetObserver:
   void OnWidgetDestroying(views::Widget* widget) override;

chrome/browser/ui/views/native_file_system/native_file_system_access_icon_view.cc

@@ -105,3 +105,7 @@ const gfx::VectorIcon& NativeFileSystemAccessIconView::GetVectorIcon() const {
   return has_write_access_ ? kSaveOriginalFileIcon
                            : vector_icons::kInsertDriveFileOutlineIcon;
 }
+
+const char* NativeFileSystemAccessIconView::GetClassName() const {
+  return "NativeFileSystemAccessIconView";
+}

chrome/browser/ui/views/native_file_system/native_file_system_access_icon_view.h

@@ -22,6 +22,7 @@ class NativeFileSystemAccessIconView : public PageActionIconView {
   base::string16 GetTextForTooltipAndAccessibleName() const override;
   void OnExecuting(ExecuteSource execute_source) override;
   const gfx::VectorIcon& GetVectorIcon() const override;
+  const char* GetClassName() const override;
 
  private:
   bool has_write_access_ = false;

chrome/browser/ui/views/page_action/page_action_icon_view.cc

@@ -192,6 +192,10 @@ void PageActionIconView::OnTouchUiChanged() {
     PreferredSizeChanged();
 }
 
+const char* PageActionIconView::GetClassName() const {
+  return "PageActionIconView";
+}
+
 void PageActionIconView::SetIconColor(SkColor icon_color) {
   icon_color_ = icon_color;
   UpdateIconImage();

chrome/browser/ui/views/page_action/page_action_icon_view.h

@@ -137,6 +137,7 @@ class PageActionIconView : public IconLabelBubbleView {
   // IconLabelBubbleView:
   void OnBoundsChanged(const gfx::Rect& previous_bounds) override;
   void OnTouchUiChanged() override;
+  const char* GetClassName() const override;
 
   // Updates the icon image after some state has changed.
   virtual void UpdateIconImage();

chrome/browser/ui/views/page_action/pwa_install_view.cc

@@ -75,3 +75,7 @@ base::string16 PwaInstallView::GetTextForTooltipAndAccessibleName() const {
       IDS_OMNIBOX_PWA_INSTALL_ICON_TOOLTIP,
       banners::AppBannerManager::GetInstallableWebAppName(web_contents));
 }
+
+const char* PwaInstallView::GetClassName() const {
+  return "PwaInstallView";
+}

chrome/browser/ui/views/page_action/pwa_install_view.h

@@ -25,6 +25,7 @@ class PwaInstallView : public PageActionIconView {
   views::BubbleDialogDelegateView* GetBubble() const override;
   const gfx::VectorIcon& GetVectorIcon() const override;
   base::string16 GetTextForTooltipAndAccessibleName() const override;
+  const char* GetClassName() const override;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PwaInstallView);

chrome/browser/ui/views/page_action/zoom_view.cc

@@ -112,3 +112,7 @@ base::string16 ZoomView::GetTextForTooltipAndAccessibleName() const {
   return l10n_util::GetStringFUTF16(IDS_TOOLTIP_ZOOM,
                                     base::FormatPercent(current_zoom_percent_));
 }
+
+const char* ZoomView::GetClassName() const {
+  return "ZoomView";
+}

chrome/browser/ui/views/page_action/zoom_view.h

@@ -30,6 +30,7 @@ class ZoomView : public PageActionIconView {
   views::BubbleDialogDelegateView* GetBubble() const override;
   const gfx::VectorIcon& GetVectorIcon() const override;
   base::string16 GetTextForTooltipAndAccessibleName() const override;
+  const char* GetClassName() const override;
 
  private:
   bool ShouldBeVisible(bool can_show_bubble) const;

chrome/browser/ui/views/qrcode_generator/qrcode_generator_icon_view.cc

@@ -67,6 +67,10 @@ const gfx::VectorIcon& QRCodeGeneratorIconView::GetVectorIcon() const {
   return kQrcodeGeneratorIcon;
 }
 
+const char* QRCodeGeneratorIconView::GetClassName() const {
+  return "QRCodeGeneratorIconView";
+}
+
 SkColor QRCodeGeneratorIconView::GetForegroundColor() const {
   return GetOmniboxColor(GetThemeProvider(),
                          OmniboxPart::LOCATION_BAR_TEXT_DEFAULT);

chrome/browser/ui/views/qrcode_generator/qrcode_generator_icon_view.h

@@ -32,6 +32,7 @@ class QRCodeGeneratorIconView : public PageActionIconView {
   // PageActionIconView:
   void OnExecuting(PageActionIconView::ExecuteSource execute_source) override;
   const gfx::VectorIcon& GetVectorIcon() const override;
+  const char* GetClassName() const override;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(QRCodeGeneratorIconView);

chrome/browser/ui/views/reader_mode/reader_mode_icon_view.cc

@@ -60,6 +60,10 @@ base::string16 ReaderModeIconView::GetTextForTooltipAndAccessibleName() const {
   return l10n_util::GetStringUTF16(IDS_DISTILL_PAGE);
 }
 
+const char* ReaderModeIconView::GetClassName() const {
+  return "ReaderModeIconView";
+}
+
 // TODO(gilmanmh): Consider displaying a bubble the first time a user
 // activates the icon to explain what Reader Mode is.
 views::BubbleDialogDelegateView* ReaderModeIconView::GetBubble() const {

chrome/browser/ui/views/reader_mode/reader_mode_icon_view.h

@@ -39,6 +39,7 @@ class ReaderModeIconView : public PageActionIconView,
   void UpdateImpl() override;
   const gfx::VectorIcon& GetVectorIcon() const override;
   base::string16 GetTextForTooltipAndAccessibleName() const override;
+  const char* GetClassName() const override;
 
   // GetBubble() is required by PageActionIconView; however, the icon
   // intentionally does not display a bubble when activated.

chrome/browser/ui/views/send_tab_to_self/send_tab_to_self_icon_view.cc

@@ -85,6 +85,10 @@ const gfx::VectorIcon& SendTabToSelfIconView::GetVectorIcon() const {
   return kSendTabToSelfIcon;
 }
 
+const char* SendTabToSelfIconView::GetClassName() const {
+  return "SendTabToSelfIconView";
+}
+
 SkColor SendTabToSelfIconView::GetForegroundColor() const {
   return GetOmniboxColor(GetThemeProvider(),
                          OmniboxPart::LOCATION_BAR_TEXT_DEFAULT);

chrome/browser/ui/views/send_tab_to_self/send_tab_to_self_icon_view.h

@@ -37,6 +37,7 @@ class SendTabToSelfIconView : public PageActionIconView {
   // PageActionIconView:
   void OnExecuting(PageActionIconView::ExecuteSource execute_source) override;
   const gfx::VectorIcon& GetVectorIcon() const override;
+  const char* GetClassName() const override;
 
  private:
   enum class AnimationState { kNotShown, kShowing, kShown };

chrome/browser/ui/views/sharing/sharing_icon_view.cc

@@ -169,3 +169,7 @@ base::string16 SharingIconView::GetTextForTooltipAndAccessibleName() const {
   return controller ? controller->GetTextForTooltipAndAccessibleName()
                     : base::string16();
 }
+
+const char* SharingIconView::GetClassName() const {
+  return "SharingIconView";
+}

chrome/browser/ui/views/sharing/sharing_icon_view.h

@@ -37,6 +37,7 @@ class SharingIconView : public PageActionIconView {
   void UpdateImpl() override;
   const gfx::VectorIcon& GetVectorIcon() const override;
   base::string16 GetTextForTooltipAndAccessibleName() const override;
+  const char* GetClassName() const override;
 
   // gfx::AnimationDelegate:
   void AnimationProgressed(const gfx::Animation* animation) override;

chrome/browser/ui/views/translate/translate_icon_view.cc

@@ -67,3 +67,7 @@ const gfx::VectorIcon& TranslateIconView::GetVectorIcon() const {
 base::string16 TranslateIconView::GetTextForTooltipAndAccessibleName() const {
   return l10n_util::GetStringUTF16(IDS_TOOLTIP_TRANSLATE);
 }
+
+const char* TranslateIconView::GetClassName() const {
+  return "TranslateIconView";
+}

chrome/browser/ui/views/translate/translate_icon_view.h

@@ -29,6 +29,7 @@ class TranslateIconView : public PageActionIconView {
   void OnPressed(bool activated) override;
   const gfx::VectorIcon& GetVectorIcon() const override;
   base::string16 GetTextForTooltipAndAccessibleName() const override;
+  const char* GetClassName() const override;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(TranslateIconView);