Fix app list test that assumed that a nonempty searchbox should be

inactive. Even if there is only whitespace in the searchbox, it
should still be active. In addition, clearing the searchbox from
the app list view creates easy opportunities for infinite loops.

Bug: 740662
Change-Id: I9806242ac448dfb7a2a0d2af34388aa3fa3c47d8
Reviewed-on: https://chromium-review.googlesource.com/581567
Commit-Queue: Maajid <maajid@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488778}

ash/app_list/app_list_presenter_delegate_unittest.cc

@@ -808,10 +808,10 @@ TEST_F(FullscreenAppListPresenterDelegateTest, WhitespaceQuery) {
   EXPECT_TRUE(view->search_box_view()->is_search_box_active());
   EXPECT_EQ(view->app_list_state(), app_list::AppListView::HALF);
 
-  // Delete the non whitespace character, the Searchbox should deactivate and go
-  // to PEEKING
+  // Delete the non whitespace character, the Searchbox should not deactivate
+  // but go to PEEKING
   generator.PressKey(ui::VKEY_BACK, 0);
-  EXPECT_FALSE(view->search_box_view()->is_search_box_active());
+  EXPECT_TRUE(view->search_box_view()->is_search_box_active());
   EXPECT_EQ(view->app_list_state(), app_list::AppListView::PEEKING);
 }
 

ui/app_list/views/app_list_view.cc

@@ -904,7 +904,6 @@ void AppListView::SetState(AppListState new_state) {
           new_widget_bounds.set_y(peeking_app_list_y);
           app_list_main_view_->contents_view()->SetActiveState(
               AppListModel::STATE_START);
-          search_box_view()->ClearSearch();
           break;
         }
         case FULLSCREEN_SEARCH: