Commit 18dc35b8 authored by Aaron Krajeski's avatar Aaron Krajeski Committed by Commit Bot

Remove CanvasRenderingContext::NeedsFinalizeFrame

This function was being overridden twice, but was never called anywhere.

Bug: 1005911
Change-Id: Ia17aaf20ed47ccad80571438578d0b62911cc7f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856918Reviewed-by: default avatarJuanmi Huertas <juanmihd@chromium.org>
Reviewed-by: default avatarFernando Serboncini <fserb@chromium.org>
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706461}
parent 177c6d00
...@@ -116,10 +116,6 @@ void CanvasRenderingContext::DidDraw() { ...@@ -116,10 +116,6 @@ void CanvasRenderingContext::DidDraw() {
StartListeningForDidProcessTask(); StartListeningForDidProcessTask();
} }
void CanvasRenderingContext::NeedsFinalizeFrame() {
StartListeningForDidProcessTask();
}
void CanvasRenderingContext::DidProcessTask( void CanvasRenderingContext::DidProcessTask(
const base::PendingTask& /* pending_task */) { const base::PendingTask& /* pending_task */) {
StopListeningForDidProcessTask(); StopListeningForDidProcessTask();
......
...@@ -134,7 +134,6 @@ class CORE_EXPORT CanvasRenderingContext : public ScriptWrappable, ...@@ -134,7 +134,6 @@ class CORE_EXPORT CanvasRenderingContext : public ScriptWrappable,
// the contents of the canvas (called didDraw). It marks the completion // the contents of the canvas (called didDraw). It marks the completion
// of a presentable frame. // of a presentable frame.
virtual void FinalizeFrame() {} virtual void FinalizeFrame() {}
void NeedsFinalizeFrame();
// Thread::TaskObserver implementation // Thread::TaskObserver implementation
void DidProcessTask(const base::PendingTask&) override; void DidProcessTask(const base::PendingTask&) override;
......
...@@ -364,7 +364,6 @@ class MODULES_EXPORT BaseRenderingContext2D : public GarbageCollectedMixin, ...@@ -364,7 +364,6 @@ class MODULES_EXPORT BaseRenderingContext2D : public GarbageCollectedMixin,
mutable UsageCounters usage_counters_; mutable UsageCounters usage_counters_;
virtual void FinalizeFrame() {} virtual void FinalizeFrame() {}
virtual void NeedsFinalizeFrame() {}
float GetFontBaseline(const SimpleFontData&) const; float GetFontBaseline(const SimpleFontData&) const;
......
...@@ -201,9 +201,6 @@ class MODULES_EXPORT CanvasRenderingContext2D final ...@@ -201,9 +201,6 @@ class MODULES_EXPORT CanvasRenderingContext2D final
CanvasColorParams ColorParamsForTest() const { return ColorParams(); } CanvasColorParams ColorParamsForTest() const { return ColorParams(); }
protected: protected:
void NeedsFinalizeFrame() override {
CanvasRenderingContext::NeedsFinalizeFrame();
}
CanvasColorParams ColorParams() const override; CanvasColorParams ColorParams() const override;
bool WritePixels(const SkImageInfo& orig_info, bool WritePixels(const SkImageInfo& orig_info,
const void* pixels, const void* pixels,
......
...@@ -125,9 +125,6 @@ class MODULES_EXPORT OffscreenCanvasRenderingContext2D final ...@@ -125,9 +125,6 @@ class MODULES_EXPORT OffscreenCanvasRenderingContext2D final
bool HasRecordedDrawCommands() { return have_recorded_draw_commands_; } bool HasRecordedDrawCommands() { return have_recorded_draw_commands_; }
protected: protected:
void NeedsFinalizeFrame() override {
CanvasRenderingContext::NeedsFinalizeFrame();
}
CanvasColorParams ColorParams() const override; CanvasColorParams ColorParams() const override;
bool WritePixels(const SkImageInfo& orig_info, bool WritePixels(const SkImageInfo& orig_info,
const void* pixels, const void* pixels,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment