[code coverage] Split linux-code-coverage-generation as builder/tester.

Since our primary objective is to reduce the cycle time for repo-wide
code coverage reports, we'd do better to have compilation and test
running on separate builders.

R=stgao,liaoyuke,jbudorick

Bug: 896446
Change-Id: Ic8b7f6319b208405a310694134da6011b485d8f1
Reviewed-on: https://chromium-review.googlesource.com/c/1289075
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601395}

infra/config/global/cr-buildbucket.cfg

@@ -1848,7 +1848,12 @@ buckets {
 
     # Code coverage reports generation bots.
     builders {
-      name: "linux-code-coverage-generation"
+      name: "linux-code-coverage-builder"
+      mixins: "code-coverage"
+      dimensions: "cores:32"
+    }
+    builders {
+      name: "linux-code-coverage-tester"
       mixins: "code-coverage"
       dimensions: "cores:32"
     }

infra/config/global/luci-milo.cfg

@@ -2446,9 +2446,14 @@ consoles {
     category: "closure_compilation"
   }
   builders {
-    name: "buildbucket/luci.chromium.ci/linux-code-coverage-generation"
-    category: "code_coverage"
-    short_name: "linux"
+    name: "buildbucket/luci.chromium.ci/linux-code-coverage-builder"
+    category: "code_coverage|linux"
+    short_name: "bld"
+  }
+  builders {
+    name: "buildbucket/luci.chromium.ci/linux-code-coverage-tester"
+    category: "code_coverage|linux"
+    short_name: "tst"
   }
   builders {
     name: "buildbucket/luci.chromium.ci/mac-code-coverage-generation"
@@ -2805,9 +2810,14 @@ consoles {
     category: "closure_compilation"
   }
   builders {
-    name: "buildbucket/luci.chromium.ci/linux-code-coverage-generation"
-    category: "code_coverage"
-    short_name: "linux"
+    name: "buildbucket/luci.chromium.ci/linux-code-coverage-builder"
+    category: "code_coverage|linux"
+    short_name: "bld"
+  }
+  builders {
+    name: "buildbucket/luci.chromium.ci/linux-code-coverage-tester"
+    category: "code_coverage|linux"
+    short_name: "tst"
   }
   builders {
     name: "buildbucket/luci.chromium.ci/mac-code-coverage-generation"

infra/config/global/luci-scheduler.cfg

@@ -308,7 +308,7 @@ trigger {
   triggers: "linux-chromeos-dbg"
   triggers: "linux-chromeos-rel"
   triggers: "linux-chromium-tests-staging-builder"
-  triggers: "linux-code-coverage-generation"
+  triggers: "linux-code-coverage-builder"
   triggers: "linux-dbg"
   triggers: "linux-gcc-rel"
   triggers: "linux-jumbo-rel"
@@ -1538,12 +1538,23 @@ job {
 }
 
 job {
-  id: "linux-code-coverage-generation"
+  id: "linux-code-coverage-builder"
   acl_sets: "default"
   buildbucket: {
     server: "cr-buildbucket.appspot.com"
     bucket: "luci.chromium.ci"
-    builder: "linux-code-coverage-generation"
+    builder: "linux-code-coverage-builder"
+  }
+}
+
+job {
+  id: "linux-code-coverage-tester"
+  # Triggered by "linux-code-coverage-buidler".
+  acl_sets: "triggered-by-parent-builders"
+  buildbucket: {
+    server: "cr-buildbucket.appspot.com"
+    bucket: "luci.chromium.ci"
+    builder: "linux-code-coverage-tester"
   }
 }
 

testing/buildbot/chromium.fyi.json

@@ -5747,7 +5747,7 @@
       }
     ]
   },
-  "linux-code-coverage-generation": {
+  "linux-code-coverage-tester": {
     "gtest_tests": [
       {
         "isolate_coverage_data": true,

testing/buildbot/waterfalls.pyl

@@ -1375,7 +1375,7 @@
           'isolated_scripts': 'chromium_linux_rel_isolated_scripts',
         },
       },
-      'linux-code-coverage-generation': {
+      'linux-code-coverage-tester': {
         'mixins': [
             'code-coverage',
         ],

tools/mb/mb_config.pyl

@@ -230,7 +230,8 @@
       'linux-blink-heap-incremental-marking': 'debug_bot_enable_blink_heap_incremental_marking',
       'linux-blink-heap-verification': 'release_bot_enable_blink_heap_verification_dcheck_always_on',
       'linux-chromium-tests-staging-builder': 'release_bot',
-      'linux-code-coverage-generation': 'clang_code_coverage',
+      'linux-code-coverage-builder': 'clang_code_coverage',
+      'linux-code-coverage-tester': 'clang_code_coverage',
       'Mac deterministic': 'release_bot_mac_strip',
       'Mac deterministic (dbg)': 'debug_bot',