Commit 18e82a3b authored by Gauthier Ambard's avatar Gauthier Ambard Committed by Commit Bot

[iOS] Fix animation glitch on TabGrid

This CL removes the animation of the content offset of the TabGrid which
allows the selected tab to be at the top of the collection.
When BVC is presented the animation isn't seen. When it is contained,
the animation was creating a visible glitch.

Fixed: 1056611
Change-Id: I8b32e8191c413e368f75c88dce1fee0665f6d075
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095722Reviewed-by: default avatarMark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748659}
parent 06e1e3e2
......@@ -243,7 +243,7 @@ NSIndexPath* CreateIndexPath(NSInteger index) {
return;
}
[self.collectionView selectItemAtIndexPath:CreateIndexPath(self.selectedIndex)
animated:animated
animated:NO
scrollPosition:UICollectionViewScrollPositionTop];
// Update the delegate, in case it wasn't set when |items| was populated.
[self.delegate gridViewController:self didChangeItemCount:self.items.count];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment