Commit 18e90f62 authored by yzshen's avatar yzshen Committed by Commit bot

Omnibox.mojom: make input_string non-nullable.

The bug in JavaScript encoder that prevented us from doing so has been fixed.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/509173003

Cr-Commit-Position: refs/heads/master@{#292419}
parent ed51a58f
...@@ -49,10 +49,7 @@ struct OmniboxResultMojo { ...@@ -49,10 +49,7 @@ struct OmniboxResultMojo {
[Client=OmniboxPage] [Client=OmniboxPage]
interface OmniboxUIHandlerMojo { interface OmniboxUIHandlerMojo {
// TODO(yzshen): Conceptually |input_string| could be non-nullable. However, StartOmniboxQuery(string input_string,
// crbug.com/407258 (JavaScript encoder encodes empty string as null) prevents
// us from doing so. Change it into non-nullable once the bug is resolved.
StartOmniboxQuery(string? input_string,
int32 cursor_position, int32 cursor_position,
bool prevent_inline_autocomplete, bool prevent_inline_autocomplete,
bool prefer_keyword, bool prefer_keyword,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment