Commit 18fdc1ab authored by Weilun Shi's avatar Weilun Shi Committed by Commit Bot

Cleanup unused fieldtrial related field

Remove fieldtrial related logic in extract_histograms.py as these fields
are not used.

Bug: 1115228
Change-Id: Ifd5e654203c12e573da02f133f339005c68ebe56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350130
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Auto-Submit: Weilun Shi <sweilun@chromium.org>
Reviewed-by: default avatarSteven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797010}
parent f6eb5c65
......@@ -86,11 +86,6 @@ EXPIRY_MILESTONE_RE = re.compile(r'M[0-9]{2,3}\Z')
_ELEMENT_NODE = xml.dom.minidom.Node.ELEMENT_NODE
# List of fields that need to copied by copy.copy to suffixed histogram.
# Other fields may be copied by reference.
_HISTOGRAM_COPY_FIELDS = [
'fieldtrial_groups', 'fieldtrial_names', 'fieldtrial_labels']
class Error(Exception):
pass
......@@ -713,14 +708,6 @@ def _UpdateHistogramsWithSuffixes(tree, histograms):
suffix_label = suffix_labels.get(suffix_name, '')
histogram_entry = histograms[new_histogram_name]
for field_name in _HISTOGRAM_COPY_FIELDS:
histogram_entry.setdefault(field_name, [])
# TODO(yiyaoliu): Rename these to be consistent with the new naming.
# It is kept unchanged for now to be it's used by dashboards.
histogram_entry['fieldtrial_groups'].append(suffix_name)
histogram_entry['fieldtrial_names'].append(name)
histogram_entry['fieldtrial_labels'].append(suffix_label)
# If no owners are added for this histogram-suffixes, it inherits the
# owners of its parents.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment