Commit 18fe7842 authored by Sergey Ulanov's avatar Sergey Ulanov Committed by Commit Bot

Fix failing CHECKs() in net_unittests on Fuchsia

crrev.com/530587 added invalid CHECKs that are always failing on Fuchsia:
the checked condition was reversed by mistake.

TBR=mmenke@chromium.org

Change-Id: I71a6273c219634e5bb76b195020f5771d13231b5
Reviewed-on: https://chromium-review.googlesource.com/877442Reviewed-by: default avatarSergey Ulanov <sergeyu@chromium.org>
Reviewed-by: default avatarWez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530737}
parent 943ef18e
...@@ -97,7 +97,7 @@ bool RemoteTestServer::StartInBackground() { ...@@ -97,7 +97,7 @@ bool RemoteTestServer::StartInBackground() {
!ssl_options().GetOCSPArgument().empty()); !ssl_options().GetOCSPArgument().empty());
if (config_.address() != IPAddress::IPv4Localhost() && ocsp_server_enabled) { if (config_.address() != IPAddress::IPv4Localhost() && ocsp_server_enabled) {
ocsp_proxy_ = std::make_unique<TcpSocketProxy>(io_thread_.task_runner()); ocsp_proxy_ = std::make_unique<TcpSocketProxy>(io_thread_.task_runner());
bool initialized = !ocsp_proxy_->Initialize(); bool initialized = ocsp_proxy_->Initialize();
CHECK(initialized); CHECK(initialized);
arguments_dict.SetKey("ocsp-proxy-port-number", arguments_dict.SetKey("ocsp-proxy-port-number",
base::Value(ocsp_proxy_->local_port())); base::Value(ocsp_proxy_->local_port()));
...@@ -137,7 +137,7 @@ bool RemoteTestServer::BlockUntilStarted() { ...@@ -137,7 +137,7 @@ bool RemoteTestServer::BlockUntilStarted() {
if (config_.address() != IPAddress::IPv4Localhost()) { if (config_.address() != IPAddress::IPv4Localhost()) {
test_server_proxy_ = test_server_proxy_ =
std::make_unique<TcpSocketProxy>(io_thread_.task_runner()); std::make_unique<TcpSocketProxy>(io_thread_.task_runner());
bool initialized = !test_server_proxy_->Initialize(); bool initialized = test_server_proxy_->Initialize();
CHECK(initialized); CHECK(initialized);
test_server_proxy_->Start(IPEndPoint(config_.address(), remote_port_)); test_server_proxy_->Start(IPEndPoint(config_.address(), remote_port_));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment