[Omnibox] Resize the thumbnail if it is larger than expected

Bug: 1090164
Change-Id: I5ce8101b3d14ec0aea02478eee919fa92c1f3261
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226081
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774873}

chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/base/BaseSuggestionViewProcessor.java

@@ -54,6 +54,13 @@ public abstract class BaseSuggestionViewProcessor implements SuggestionProcessor
                 R.dimen.omnibox_suggestion_comfortable_height);
     }
 
+    /**
+     * @return The desired size of Omnibox suggestion favicon.
+     */
+    protected int getDesiredFaviconSize() {
+        return mDesiredFaviconWidthPx;
+    }
+
     @Override
     public void onNativeInitialized() {
         if (ChromeFeatureList.isEnabled(ChromeFeatureList.OMNIBOX_COMPACT_SUGGESTIONS)) {

chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/clipboard/ClipboardSuggestionProcessor.java

@@ -73,6 +73,18 @@ public class ClipboardSuggestionProcessor extends BaseSuggestionViewProcessor {
             if (imageData != null && imageData.length > 0) {
                 Bitmap bitmap = BitmapFactory.decodeByteArray(imageData, 0, imageData.length);
                 if (bitmap != null) {
+                    // TODO(crbug.com/1090919): This is short term solution, resize need to be
+                    // handled somewhere else.
+                    if (bitmap.getWidth() > 0 && bitmap.getHeight() > 0
+                            && (bitmap.getWidth() > getDesiredFaviconSize()
+                                    || bitmap.getHeight() > getDesiredFaviconSize())) {
+                        float max = Math.max(bitmap.getWidth(), bitmap.getHeight());
+                        float scale = (float) getDesiredFaviconSize() / max;
+                        float width = bitmap.getWidth();
+                        float height = bitmap.getHeight();
+                        bitmap = Bitmap.createScaledBitmap(bitmap, (int) Math.round(scale * width),
+                                (int) Math.round(scale * height), true);
+                    }
                     setSuggestionDrawableState(model,
                             SuggestionDrawableState.Builder.forBitmap(getContext(), bitmap)
                                     .build());

chrome/android/native_java_unittests/src/org/chromium/chrome/browser/omnibox/suggestions/clipboard/ClipboardSuggestionProcessorTest.java

@@ -197,4 +197,22 @@ public class ClipboardSuggestionProcessorTest {
         Assert.assertEquals(
                 mBitmap.getHeight(), ((BitmapDrawable) icon.drawable).getBitmap().getHeight());
     }
+
+    @CalledByNativeJavaTest
+    public void clipboardSuggestion_thumbnailShouldResizeIfTooLarge() {
+        int size = ContextUtils.getApplicationContext().getResources().getDimensionPixelSize(
+                R.dimen.omnibox_suggestion_favicon_size);
+
+        Bitmap largeBitmap = Bitmap.createBitmap(size * 2, size * 2, Config.ARGB_8888);
+        ByteArrayOutputStream baos = new ByteArrayOutputStream();
+        Assert.assertTrue(largeBitmap.compress(Bitmap.CompressFormat.PNG, 100, baos));
+        byte[] bitmapData = baos.toByteArray();
+        createClipboardSuggestion(
+                OmniboxSuggestionType.CLIPBOARD_IMAGE, GURL.emptyGURL(), bitmapData);
+        SuggestionDrawableState icon = mModel.get(BaseSuggestionViewProperties.ICON);
+        Assert.assertNotNull(icon);
+
+        Assert.assertEquals(size, ((BitmapDrawable) icon.drawable).getBitmap().getWidth());
+        Assert.assertEquals(size, ((BitmapDrawable) icon.drawable).getBitmap().getHeight());
+    }
 }