Commit 1925b354 authored by Jaeyong Bae's avatar Jaeyong Bae Committed by Commit Bot

[IndexedDB] Remove tracing in hot codepaths

This patch means remove tracing to make IndexedDB
(and more importantly, compaction) faster.

Bug: 1012883
Change-Id: I0f05171ecf8986d8cccdc151243e1de02d124090
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851365
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: default avatarDaniel Murphy <dmurph@chromium.org>
Reviewed-by: default avatarVictor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704918}
parent 28a52831
...@@ -213,8 +213,9 @@ class ChromiumSequentialFile : public leveldb::SequentialFile { ...@@ -213,8 +213,9 @@ class ChromiumSequentialFile : public leveldb::SequentialFile {
: filename_(fname), file_(std::move(f)), uma_logger_(uma_logger) {} : filename_(fname), file_(std::move(f)), uma_logger_(uma_logger) {}
virtual ~ChromiumSequentialFile() {} virtual ~ChromiumSequentialFile() {}
// Note: This method is relatively hot during leveldb database
// compaction. Please avoid making them slower.
Status Read(size_t n, Slice* result, char* scratch) override { Status Read(size_t n, Slice* result, char* scratch) override {
TRACE_EVENT1("leveldb", "ChromiumSequentialFile::Read", "size", n);
int bytes_read = file_.ReadAtCurrentPosNoBestEffort(scratch, n); int bytes_read = file_.ReadAtCurrentPosNoBestEffort(scratch, n);
if (bytes_read == -1) { if (bytes_read == -1) {
base::File::Error error = base::File::GetLastFileError(); base::File::Error error = base::File::GetLastFileError();
...@@ -306,12 +307,12 @@ class ChromiumEvictableRandomAccessFile : public leveldb::RandomAccessFile { ...@@ -306,12 +307,12 @@ class ChromiumEvictableRandomAccessFile : public leveldb::RandomAccessFile {
file_cache_->Erase(cache_key_); file_cache_->Erase(cache_key_);
} }
// Note: This method is relatively hot during leveldb database
// compaction. Please avoid making them slower.
Status Read(uint64_t offset, Status Read(uint64_t offset,
size_t n, size_t n,
Slice* result, Slice* result,
char* scratch) const override { char* scratch) const override {
TRACE_EVENT2("leveldb", "ChromiumEvictableRandomAccessFile::Read", "offset",
offset, "size", n);
leveldb::Cache::Handle* handle = file_cache_->Lookup(cache_key_); leveldb::Cache::Handle* handle = file_cache_->Lookup(cache_key_);
if (!handle) { if (!handle) {
int flags = base::File::FLAG_READ | base::File::FLAG_OPEN; int flags = base::File::FLAG_READ | base::File::FLAG_OPEN;
...@@ -351,12 +352,12 @@ class ChromiumRandomAccessFile : public leveldb::RandomAccessFile { ...@@ -351,12 +352,12 @@ class ChromiumRandomAccessFile : public leveldb::RandomAccessFile {
virtual ~ChromiumRandomAccessFile() {} virtual ~ChromiumRandomAccessFile() {}
// Note: This method is relatively hot during leveldb database
// compaction. Please avoid making them slower.
Status Read(uint64_t offset, Status Read(uint64_t offset,
size_t n, size_t n,
Slice* result, Slice* result,
char* scratch) const override { char* scratch) const override {
TRACE_EVENT2("leveldb", "ChromiumRandomAccessFile::Read", "offset", offset,
"size", n);
return ReadFromFileToScratch(offset, n, result, scratch, &file_, filepath_, return ReadFromFileToScratch(offset, n, result, scratch, &file_, filepath_,
uma_logger_); uma_logger_);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment