Commit 1960c094 authored by Eric Sum's avatar Eric Sum Committed by Commit Bot

Remove "testonly" in absl's command line flag GN targets.

See internal buganizer bug for context.

Bug: internal b/163291366
Test: Build locally.
Change-Id: Iac091d9a0cd9d4c39e22b51a1d89a442536e9909
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345723Reviewed-by: default avatarMirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Eric Sum <esum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797638}
parent 760c905c
...@@ -4,13 +4,7 @@ ...@@ -4,13 +4,7 @@
import("//third_party/abseil-cpp/absl.gni") import("//third_party/abseil-cpp/absl.gni")
# Build targets in this module are marked as "testonly" because it is not clear
# how ABSL_FLAG will interact with //base/command_line.h.
# If this is a problem, feel free to remove "testonly" and use "assert_no_deps"
# on the main Chrome binary.
absl_source_set("path_util") { absl_source_set("path_util") {
testonly = true
public = [ "internal/path_util.h" ] public = [ "internal/path_util.h" ]
deps = [ deps = [
"//third_party/abseil-cpp/absl/base:config", "//third_party/abseil-cpp/absl/base:config",
...@@ -20,7 +14,6 @@ absl_source_set("path_util") { ...@@ -20,7 +14,6 @@ absl_source_set("path_util") {
} }
absl_source_set("program_name") { absl_source_set("program_name") {
testonly = true
sources = [ "internal/program_name.cc" ] sources = [ "internal/program_name.cc" ]
public = [ "internal/program_name.h" ] public = [ "internal/program_name.h" ]
deps = [ deps = [
...@@ -34,7 +27,6 @@ absl_source_set("program_name") { ...@@ -34,7 +27,6 @@ absl_source_set("program_name") {
} }
absl_source_set("config") { absl_source_set("config") {
testonly = true
sources = [ "usage_config.cc" ] sources = [ "usage_config.cc" ]
public = [ public = [
"config.h", "config.h",
...@@ -51,7 +43,6 @@ absl_source_set("config") { ...@@ -51,7 +43,6 @@ absl_source_set("config") {
} }
absl_source_set("marshalling") { absl_source_set("marshalling") {
testonly = true
sources = [ "marshalling.cc" ] sources = [ "marshalling.cc" ]
public = [ "marshalling.h" ] public = [ "marshalling.h" ]
deps = [ deps = [
...@@ -64,7 +55,6 @@ absl_source_set("marshalling") { ...@@ -64,7 +55,6 @@ absl_source_set("marshalling") {
} }
absl_source_set("commandlineflag_internal") { absl_source_set("commandlineflag_internal") {
testonly = true
public = [ "internal/commandlineflag.h" ] public = [ "internal/commandlineflag.h" ]
sources = [ "internal/commandlineflag.cc" ] sources = [ "internal/commandlineflag.cc" ]
deps = [ deps = [
...@@ -75,7 +65,6 @@ absl_source_set("commandlineflag_internal") { ...@@ -75,7 +65,6 @@ absl_source_set("commandlineflag_internal") {
} }
absl_source_set("commandlineflag") { absl_source_set("commandlineflag") {
testonly = true
sources = [ "commandlineflag.cc" ] sources = [ "commandlineflag.cc" ]
public = [ "commandlineflag.h" ] public = [ "commandlineflag.h" ]
deps = [ deps = [
...@@ -88,7 +77,6 @@ absl_source_set("commandlineflag") { ...@@ -88,7 +77,6 @@ absl_source_set("commandlineflag") {
} }
absl_source_set("private_handle_accessor") { absl_source_set("private_handle_accessor") {
testonly = true
sources = [ "internal/private_handle_accessor.cc" ] sources = [ "internal/private_handle_accessor.cc" ]
public = [ "internal/private_handle_accessor.h" ] public = [ "internal/private_handle_accessor.h" ]
deps = [ deps = [
...@@ -101,7 +89,6 @@ absl_source_set("private_handle_accessor") { ...@@ -101,7 +89,6 @@ absl_source_set("private_handle_accessor") {
} }
absl_source_set("reflection") { absl_source_set("reflection") {
testonly = true
sources = [ "reflection.cc" ] sources = [ "reflection.cc" ]
public = [ public = [
"internal/registry.h", "internal/registry.h",
...@@ -120,7 +107,6 @@ absl_source_set("reflection") { ...@@ -120,7 +107,6 @@ absl_source_set("reflection") {
} }
absl_source_set("flag_internal") { absl_source_set("flag_internal") {
testonly = true
sources = [ "internal/flag.cc" ] sources = [ "internal/flag.cc" ]
public = [ "internal/flag.h" ] public = [ "internal/flag.h" ]
deps = [ deps = [
...@@ -145,7 +131,6 @@ absl_source_set("flag_internal") { ...@@ -145,7 +131,6 @@ absl_source_set("flag_internal") {
} }
absl_source_set("flag") { absl_source_set("flag") {
testonly = true
sources = [ "flag.cc" ] sources = [ "flag.cc" ]
public = [ public = [
"declare.h", "declare.h",
...@@ -163,7 +148,6 @@ absl_source_set("flag") { ...@@ -163,7 +148,6 @@ absl_source_set("flag") {
} }
absl_source_set("usage_internal") { absl_source_set("usage_internal") {
testonly = true
sources = [ "internal/usage.cc" ] sources = [ "internal/usage.cc" ]
public = [ "internal/usage.h" ] public = [ "internal/usage.h" ]
deps = [ deps = [
...@@ -183,7 +167,6 @@ absl_source_set("usage_internal") { ...@@ -183,7 +167,6 @@ absl_source_set("usage_internal") {
} }
absl_source_set("usage") { absl_source_set("usage") {
testonly = true
sources = [ "usage.cc" ] sources = [ "usage.cc" ]
public = [ "usage.h" ] public = [ "usage.h" ]
deps = [ deps = [
...@@ -196,7 +179,6 @@ absl_source_set("usage") { ...@@ -196,7 +179,6 @@ absl_source_set("usage") {
} }
absl_source_set("parse") { absl_source_set("parse") {
testonly = true
sources = [ "parse.cc" ] sources = [ "parse.cc" ]
public = [ public = [
"internal/parse.h", "internal/parse.h",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment