Commit 1971da72 authored by Guido Urdaneta's avatar Guido Urdaneta Committed by Commit Bot

Revert "Disable flaky WebRtcMediaRecorderTest.StartAndDataAvailable on TSAN"

This reverts commit 80d89eb4.

Reason for revert: The TSAN failure is a more general failure affected lots of test. It's not specific to this test. Once the general problem is fixed, this test should stop flaking.

Original change's description:
> Disable flaky WebRtcMediaRecorderTest.StartAndDataAvailable on TSAN
> 
> Bug: 1043828
> Change-Id: I41db446ceec894c06b15c40a673f290f8ba2e533
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030886
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Armando Miraglia <armax@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#736876}

TBR=guidou@chromium.org,armax@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1043828
Change-Id: Ib06dd710488a087ab24c409691107c7c1360dfad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033767Reviewed-by: default avatarGuido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737702}
parent d6aa5900
...@@ -84,14 +84,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest, StartAndStop) { ...@@ -84,14 +84,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest, StartAndStop) {
MakeTypicalCall("testStartStopAndRecorderState();", kMediaRecorderHtmlFile); MakeTypicalCall("testStartStopAndRecorderState();", kMediaRecorderHtmlFile);
} }
// Flaky on TSAN. See https://crbug.com/1043828 IN_PROC_BROWSER_TEST_P(MAYBE_WebRtcMediaRecorderTest, StartAndDataAvailable) {
#if defined(THREAD_SANITIZER)
#define MAYBE_StartAndDataAvailable DISABLED_StartAndDataAvailable
#else
#define MAYBE_StartAndDataAvailable StartAndDataAvailable
#endif
IN_PROC_BROWSER_TEST_P(MAYBE_WebRtcMediaRecorderTest,
MAYBE_StartAndDataAvailable) {
MaybeForceDisableEncodeAccelerator(GetParam().disable_accelerator); MaybeForceDisableEncodeAccelerator(GetParam().disable_accelerator);
MakeTypicalCall(base::StringPrintf("testStartAndDataAvailable(\"%s\");", MakeTypicalCall(base::StringPrintf("testStartAndDataAvailable(\"%s\");",
GetParam().mime_type.c_str()), GetParam().mime_type.c_str()),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment