Commit 19862c71 authored by Xianzhu Wang's avatar Xianzhu Wang Committed by Commit Bot

[CompositeAfterPaint] Fix feImage filter

The original code mistakenly assumed that no filter can create visual
effects from nothing, but feImage is one of the exceptions.

Change-Id: Icc9fc0717522a0ea19da29143dd35b66663f1922
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250708Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780038}
parent e8474c58
......@@ -115,9 +115,10 @@ scoped_refptr<cc::PictureLayer> ContentLayerClientImpl::UpdateCcPictureLayer(
cc_picture_layer_->SetIsDrawable(
(!layer_bounds.IsEmpty() && cc_display_item_list_->TotalOpCount()) ||
// Backdrop effects require the layer to be drawable even if the layer
// draws nothing.
layer_state.Effect().HasBackdropEffect());
// Backdrop effects and filters require the layer to be drawable even if
// the layer draws nothing.
layer_state.Effect().HasBackdropEffect() ||
!layer_state.Effect().Filter().IsEmpty());
auto safe_opaque_background_color =
paint_artifact->SafeOpaqueBackgroundColor(paint_chunks);
......
......@@ -47,7 +47,6 @@ crbug.com/957674 external/wpt/largest-contentful-paint/invisible-images-composit
crbug.com/957674 virtual/scalefactor200/external/wpt/largest-contentful-paint/invisible-images-composited-2.html [ Pass ]
external/wpt/css/css-transforms/transform3d-backface-visibility-006.html [ Failure ]
external/wpt/css/filter-effects/effect-reference-feimage-002.html [ Failure ]
printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages.html [ Failure ]
printing/fixed-positioned-headers-and-footers-larger-than-page.html [ Failure ]
......@@ -74,5 +73,8 @@ http/tests/devtools/layers/layer-scroll-rects-get.js [ Failure ]
# Outline paints incorrectly with columns.
crbug.com/1047358 paint/pagination/composited-paginated-outlined-box.html [ Failure ]
# Ad frame highlight size is incorrect
crbug.com/1047359 http/tests/subresource_filter/ad-highlight-frame-resized.html [ Pass Failure ]
compositing/gestures/gesture-tapHighlight-composited-img.html [ Pass Failure ]
http/tests/images/image-decode-in-frame.html [ Pass Failure ]
......@@ -9,8 +9,7 @@
{
"name": "LayoutNGBlockFlow DIV class='blur'",
"position": [8, 8],
"bounds": [200, 200],
"drawsContent": false
"bounds": [200, 200]
},
{
"name": "LayoutNGBlockFlow DIV class='accelerated'",
......
......@@ -9,7 +9,6 @@
{
"name": "LayoutNGBlockFlow DIV class='blur accelerated'",
"bounds": [200, 200],
"drawsContent": false,
"transform": 1
},
{
......
......@@ -9,8 +9,7 @@
{
"name": "LayoutNGBlockFlow DIV class='blur'",
"position": [8, 8],
"bounds": [200, 200],
"drawsContent": false
"bounds": [200, 200]
},
{
"name": "LayoutNGBlockFlow DIV id='resize' class='accelerated'",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment