Commit 19925ec3 authored by phoglund@chromium.org's avatar phoglund@chromium.org

Revert 220320 "Disabling flaky webrtc tests for now."

> Disabling flaky webrtc tests for now.
> 
> BUG=28149
> TBR=tommi@chromium.org
> NOTRY=True
> 
> Review URL: https://chromiumcodereview.appspot.com/23592020

TBR=phoglund@chromium.org

Review URL: https://codereview.chromium.org/23702012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220572 0039d316-1c4b-4281-b951-d872f2087c98
parent 1bfe2cdb
...@@ -45,17 +45,10 @@ std::string GenerateGetUserMediaCall(const char* function_name, ...@@ -45,17 +45,10 @@ std::string GenerateGetUserMediaCall(const char* function_name,
namespace content { namespace content {
#if defined(OS_LINUX) class WebrtcBrowserTest: public ContentBrowserTest {
// All tests are flaky on Linux: crbug.com/281492.
#define MAYBE_WebrtcBrowserTest DISABLED_WebrtcBrowserTest
#else
#define MAYBE_WebrtcBrowserTest WebrtcBrowserTest
#endif
class MAYBE_WebrtcBrowserTest: public ContentBrowserTest {
public: public:
MAYBE_WebrtcBrowserTest() {} WebrtcBrowserTest() {}
virtual ~MAYBE_WebrtcBrowserTest() {} virtual ~WebrtcBrowserTest() {}
virtual void SetUpOnMainThread() OVERRIDE { virtual void SetUpOnMainThread() OVERRIDE {
ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady()); ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
...@@ -89,7 +82,7 @@ class MAYBE_WebrtcBrowserTest: public ContentBrowserTest { ...@@ -89,7 +82,7 @@ class MAYBE_WebrtcBrowserTest: public ContentBrowserTest {
// These tests will all make a getUserMedia call with different constraints and // These tests will all make a getUserMedia call with different constraints and
// see that the success callback is called. If the error callback is called or // see that the success callback is called. If the error callback is called or
// none of the callbacks are called the tests will simply time out and fail. // none of the callbacks are called the tests will simply time out and fail.
IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, GetVideoStreamAndStop) { IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, GetVideoStreamAndStop) {
GURL url(embedded_test_server()->GetURL("/media/getusermedia.html")); GURL url(embedded_test_server()->GetURL("/media/getusermedia.html"));
NavigateToURL(shell(), url); NavigateToURL(shell(), url);
...@@ -98,8 +91,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, GetVideoStreamAndStop) { ...@@ -98,8 +91,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, GetVideoStreamAndStop) {
ExpectTitle("OK"); ExpectTitle("OK");
} }
IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, GetAudioAndVideoStreamAndStop) {
GetAudioAndVideoStreamAndStop) {
GURL url(embedded_test_server()->GetURL("/media/getusermedia.html")); GURL url(embedded_test_server()->GetURL("/media/getusermedia.html"));
NavigateToURL(shell(), url); NavigateToURL(shell(), url);
...@@ -108,8 +100,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, ...@@ -108,8 +100,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest,
ExpectTitle("OK"); ExpectTitle("OK");
} }
IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, GetAudioAndVideoStreamAndClone) {
GetAudioAndVideoStreamAndClone) {
GURL url(embedded_test_server()->GetURL("/media/getusermedia.html")); GURL url(embedded_test_server()->GetURL("/media/getusermedia.html"));
NavigateToURL(shell(), url); NavigateToURL(shell(), url);
...@@ -128,7 +119,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, ...@@ -128,7 +119,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest,
// These tests will make a complete PeerConnection-based call and verify that // These tests will make a complete PeerConnection-based call and verify that
// video is playing for the call. // video is playing for the call.
IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, MAYBE_CanSetupVideoCall) { IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, MAYBE_CanSetupVideoCall) {
GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html")); GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html"));
NavigateToURL(shell(), url); NavigateToURL(shell(), url);
...@@ -143,8 +134,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, MAYBE_CanSetupVideoCall) { ...@@ -143,8 +134,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, MAYBE_CanSetupVideoCall) {
#define MAYBE_CanSetupAudioAndVideoCall CanSetupAudioAndVideoCall #define MAYBE_CanSetupAudioAndVideoCall CanSetupAudioAndVideoCall
#endif #endif
IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, MAYBE_CanSetupAudioAndVideoCall) {
MAYBE_CanSetupAudioAndVideoCall) {
GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html")); GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html"));
NavigateToURL(shell(), url); NavigateToURL(shell(), url);
...@@ -152,8 +142,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, ...@@ -152,8 +142,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest,
ExpectTitle("OK"); ExpectTitle("OK");
} }
IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, MANUAL_CanSetupCallAndSendDtmf) {
MANUAL_CanSetupCallAndSendDtmf) {
GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html")); GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html"));
NavigateToURL(shell(), url); NavigateToURL(shell(), url);
...@@ -161,7 +150,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, ...@@ -161,7 +150,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest,
ExecuteJavascript("callAndSendDtmf('123,abc');")); ExecuteJavascript("callAndSendDtmf('123,abc');"));
} }
IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest,
CanMakeEmptyCallThenAddStreamsAndRenegotiate) { CanMakeEmptyCallThenAddStreamsAndRenegotiate) {
GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html")); GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html"));
NavigateToURL(shell(), url); NavigateToURL(shell(), url);
...@@ -188,7 +177,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, ...@@ -188,7 +177,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest,
#define MAYBE_CanSetupAudioAndVideoCallWithoutMsidAndBundle\ #define MAYBE_CanSetupAudioAndVideoCallWithoutMsidAndBundle\
CanSetupAudioAndVideoCallWithoutMsidAndBundle CanSetupAudioAndVideoCallWithoutMsidAndBundle
#endif #endif
IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest,
MAYBE_CanSetupAudioAndVideoCallWithoutMsidAndBundle) { MAYBE_CanSetupAudioAndVideoCallWithoutMsidAndBundle) {
GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html")); GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html"));
NavigateToURL(shell(), url); NavigateToURL(shell(), url);
...@@ -199,7 +188,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, ...@@ -199,7 +188,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest,
// This test will make a PeerConnection-based call and test an unreliable text // This test will make a PeerConnection-based call and test an unreliable text
// dataChannel. // dataChannel.
IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, CallWithDataOnly) { IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, CallWithDataOnly) {
GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html")); GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html"));
NavigateToURL(shell(), url); NavigateToURL(shell(), url);
...@@ -216,7 +205,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, CallWithDataOnly) { ...@@ -216,7 +205,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, CallWithDataOnly) {
// This test will make a PeerConnection-based call and test an unreliable text // This test will make a PeerConnection-based call and test an unreliable text
// dataChannel and audio and video tracks. // dataChannel and audio and video tracks.
IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, MAYBE_CallWithDataAndMedia) { IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, MAYBE_CallWithDataAndMedia) {
GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html")); GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html"));
NavigateToURL(shell(), url); NavigateToURL(shell(), url);
...@@ -233,8 +222,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, MAYBE_CallWithDataAndMedia) { ...@@ -233,8 +222,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, MAYBE_CallWithDataAndMedia) {
// This test will make a PeerConnection-based call and test an unreliable text // This test will make a PeerConnection-based call and test an unreliable text
// dataChannel and later add an audio and video track. // dataChannel and later add an audio and video track.
IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, MAYBE_CallWithDataAndLaterAddMedia) {
MAYBE_CallWithDataAndLaterAddMedia) {
GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html")); GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html"));
NavigateToURL(shell(), url); NavigateToURL(shell(), url);
...@@ -252,8 +240,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, ...@@ -252,8 +240,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest,
// This test will make a PeerConnection-based call and send a new Video // This test will make a PeerConnection-based call and send a new Video
// MediaStream that has been created based on a MediaStream created with // MediaStream that has been created based on a MediaStream created with
// getUserMedia. // getUserMedia.
IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, MAYBE_CallWithNewVideoMediaStream) {
MAYBE_CallWithNewVideoMediaStream) {
GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html")); GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html"));
NavigateToURL(shell(), url); NavigateToURL(shell(), url);
...@@ -267,7 +254,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, ...@@ -267,7 +254,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest,
// AudioTrack is added instead. // AudioTrack is added instead.
// TODO(phoglund): This test is manual since not all buildbots has an audio // TODO(phoglund): This test is manual since not all buildbots has an audio
// input. // input.
IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, MANUAL_CallAndModifyStream) { IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, MANUAL_CallAndModifyStream) {
GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html")); GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html"));
NavigateToURL(shell(), url); NavigateToURL(shell(), url);
...@@ -277,7 +264,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, MANUAL_CallAndModifyStream) { ...@@ -277,7 +264,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, MANUAL_CallAndModifyStream) {
} }
// This test calls getUserMedia in sequence with different constraints. // This test calls getUserMedia in sequence with different constraints.
IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, TestGetUserMediaConstraints) { IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, TestGetUserMediaConstraints) {
GURL url(embedded_test_server()->GetURL("/media/getusermedia.html")); GURL url(embedded_test_server()->GetURL("/media/getusermedia.html"));
std::vector<std::string> list_of_get_user_media_calls; std::vector<std::string> list_of_get_user_media_calls;
...@@ -308,7 +295,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, TestGetUserMediaConstraints) { ...@@ -308,7 +295,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, TestGetUserMediaConstraints) {
} }
// This test calls getUserMedia and checks for aspect ratio behavior. // This test calls getUserMedia and checks for aspect ratio behavior.
IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, TestGetUserMediaAspectRatio) { IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, TestGetUserMediaAspectRatio) {
GURL url(embedded_test_server()->GetURL("/media/getusermedia.html")); GURL url(embedded_test_server()->GetURL("/media/getusermedia.html"));
std::string constraints_4_3 = GenerateGetUserMediaCall( std::string constraints_4_3 = GenerateGetUserMediaCall(
...@@ -327,7 +314,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, TestGetUserMediaAspectRatio) { ...@@ -327,7 +314,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, TestGetUserMediaAspectRatio) {
ExpectTitle("16:9 letterbox"); ExpectTitle("16:9 letterbox");
} }
IN_PROC_BROWSER_TEST_F(MAYBE_WebrtcBrowserTest, AddTwoMediaStreamsToOnePC) { IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, AddTwoMediaStreamsToOnePC) {
GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html")); GURL url(embedded_test_server()->GetURL("/media/peerconnection-call.html"));
NavigateToURL(shell(), url); NavigateToURL(shell(), url);
......
...@@ -118,9 +118,8 @@ class PeerConnectionEntry { ...@@ -118,9 +118,8 @@ class PeerConnectionEntry {
static const int64 FAKE_TIME_STAMP = 3600000; static const int64 FAKE_TIME_STAMP = 3600000;
#if defined(OS_WIN) || defined(OS_LINUX) #if defined(OS_WIN)
// All tests are flaky on Windows: crbug.com/277322. // All tests are flaky on Windows: crbug.com/277322.
// All tests are flaky on Linux: crbug.com/281492.
#define MAYBE_WebRTCInternalsBrowserTest DISABLED_WebRTCInternalsBrowserTest #define MAYBE_WebRTCInternalsBrowserTest DISABLED_WebRTCInternalsBrowserTest
#else #else
#define MAYBE_WebRTCInternalsBrowserTest WebRTCInternalsBrowserTest #define MAYBE_WebRTCInternalsBrowserTest WebRTCInternalsBrowserTest
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment