Commit 19a66a42 authored by Sahel Sharify's avatar Sahel Sharify Committed by Commit Bot

Fix perf regression of PassiveDocumentWheelEventListeners.

JS_SCROLL_TEXT_ONLY and JS_SCROLL_200_LAYER_GRID both add event listeners
to the document that preventDefault wheel/touch events and call JS scrolling.
The tests regressed after landing the following cl:
https://chromium-review.googlesource.com/1183538

This is because with passive document level event listeners interventions
the wheel/mousewheel and touchstart/touchmove event listeners on a document
level target are treated as passive if not requested otherwise. This cl changes
the event listeners in both tests to passive:false to make sure that they
actually prevent scrolling.

Bug: 877586
Change-Id: I25fb5c0563534b1d67f124bd43272d02d849fa23
Reviewed-on: https://chromium-review.googlesource.com/c/1329447
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: default avatarCharlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607441}
parent bbd84679
...@@ -157,10 +157,10 @@ ...@@ -157,10 +157,10 @@
"DEFAULT": "rendering_desktop_009.wprgo" "DEFAULT": "rendering_desktop_009.wprgo"
}, },
"js_scroll_200_layer_grid": { "js_scroll_200_layer_grid": {
"DEFAULT": "rendering_desktop_009.wprgo" "DEFAULT": "rendering_desktop_05c1f9e507.wprgo"
}, },
"js_scroll_text_only": { "js_scroll_text_only": {
"DEFAULT": "rendering_desktop_009.wprgo" "DEFAULT": "rendering_desktop_a2106b0095.wprgo"
}, },
"kevs_3d": { "kevs_3d": {
"DEFAULT": "rendering_desktop_004.wprgo" "DEFAULT": "rendering_desktop_004.wprgo"
......
05c1f9e5071c8a1911caa37092e4218536723f0e
\ No newline at end of file
a2106b0095c112ee3885ceab61794e4763f2b0a1
\ No newline at end of file
...@@ -47,7 +47,7 @@ class CCScrollTextPage(ToughCompositorScrollPage): ...@@ -47,7 +47,7 @@ class CCScrollTextPage(ToughCompositorScrollPage):
# Why: Baseline JS scrolling page. A long page with only text. """ # Why: Baseline JS scrolling page. A long page with only text. """
class JSScrollTextPage(ToughCompositorScrollPage): class JSScrollTextPage(ToughCompositorScrollPage):
BASE_NAME = 'js_scroll_text_only' BASE_NAME = 'js_scroll_text_only'
URL = 'http://jsbin.com/wixadinu/2/quiet?JS_SCROLL_TEXT_ONLY' URL = 'http://jsbin.com/dozirar/quiet?JS_SCROLL_TEXT_ONLY'
# Why: Scroll by a large number of CC layers """ # Why: Scroll by a large number of CC layers """
...@@ -61,7 +61,7 @@ class CCScroll200LayerPage(ToughCompositorScrollPage): ...@@ -61,7 +61,7 @@ class CCScroll200LayerPage(ToughCompositorScrollPage):
# TODO(crbug.com/878951): Remove after 'n_layer' tests below are fully landed. # TODO(crbug.com/878951): Remove after 'n_layer' tests below are fully landed.
class JSScroll200LayerPage(ToughCompositorScrollPage): class JSScroll200LayerPage(ToughCompositorScrollPage):
BASE_NAME = 'js_scroll_200_layer_grid' BASE_NAME = 'js_scroll_200_layer_grid'
URL = 'http://jsbin.com/jevibahi/4/quiet?JS_SCROLL_200_LAYER_GRID' URL = 'http://jsbin.com/jumolix/quiet?JS_SCROLL_200_LAYER_GRID'
class ToughCompositorWaitPage(ToughCompositorPage): class ToughCompositorWaitPage(ToughCompositorPage):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment