Commit 19adfcc2 authored by nisse's avatar nisse Committed by Commit bot

Replace all use of cricket::VideoFrame and cricket::WebRtcVideoFrame with webrtc::VideoFrame.

These classes are deprecated in webrtc.

BUG=webrtc:5682

Review-Url: https://codereview.chromium.org/2466353003
Cr-Commit-Position: refs/heads/master@{#430257}
parent 2a787d8f
...@@ -16,7 +16,6 @@ ...@@ -16,7 +16,6 @@
#include "media/base/timestamp_constants.h" #include "media/base/timestamp_constants.h"
#include "media/base/video_frame.h" #include "media/base/video_frame.h"
#include "media/base/video_util.h" #include "media/base/video_util.h"
#include "third_party/webrtc/media/base/videoframe.h"
#include "third_party/webrtc/media/base/videosinkinterface.h" #include "third_party/webrtc/media/base/videosinkinterface.h"
namespace content { namespace content {
...@@ -44,7 +43,7 @@ media::VideoRotation WebRTCToMediaVideoRotation( ...@@ -44,7 +43,7 @@ media::VideoRotation WebRTCToMediaVideoRotation(
// libjingle thread and forward it to the IO-thread. // libjingle thread and forward it to the IO-thread.
class MediaStreamRemoteVideoSource::RemoteVideoSourceDelegate class MediaStreamRemoteVideoSource::RemoteVideoSourceDelegate
: public base::RefCountedThreadSafe<RemoteVideoSourceDelegate>, : public base::RefCountedThreadSafe<RemoteVideoSourceDelegate>,
public rtc::VideoSinkInterface<cricket::VideoFrame> { public rtc::VideoSinkInterface<webrtc::VideoFrame> {
public: public:
RemoteVideoSourceDelegate( RemoteVideoSourceDelegate(
scoped_refptr<base::SingleThreadTaskRunner> io_task_runner, scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,
...@@ -57,7 +56,7 @@ class MediaStreamRemoteVideoSource::RemoteVideoSourceDelegate ...@@ -57,7 +56,7 @@ class MediaStreamRemoteVideoSource::RemoteVideoSourceDelegate
// Implements rtc::VideoSinkInterface used for receiving video frames // Implements rtc::VideoSinkInterface used for receiving video frames
// from the PeerConnection video track. May be called on a libjingle internal // from the PeerConnection video track. May be called on a libjingle internal
// thread. // thread.
void OnFrame(const cricket::VideoFrame& frame) override; void OnFrame(const webrtc::VideoFrame& frame) override;
void DoRenderFrameOnIOThread( void DoRenderFrameOnIOThread(
const scoped_refptr<media::VideoFrame>& video_frame); const scoped_refptr<media::VideoFrame>& video_frame);
...@@ -96,7 +95,7 @@ void DoNothing(const scoped_refptr<rtc::RefCountInterface>& ref) {} ...@@ -96,7 +95,7 @@ void DoNothing(const scoped_refptr<rtc::RefCountInterface>& ref) {}
} // anonymous } // anonymous
void MediaStreamRemoteVideoSource::RemoteVideoSourceDelegate::OnFrame( void MediaStreamRemoteVideoSource::RemoteVideoSourceDelegate::OnFrame(
const cricket::VideoFrame& incoming_frame) { const webrtc::VideoFrame& incoming_frame) {
const base::TimeDelta incoming_timestamp = base::TimeDelta::FromMicroseconds( const base::TimeDelta incoming_timestamp = base::TimeDelta::FromMicroseconds(
incoming_frame.timestamp_us()); incoming_frame.timestamp_us());
const base::TimeTicks render_time = const base::TimeTicks render_time =
...@@ -226,7 +225,7 @@ void MediaStreamRemoteVideoSource::StopSourceImpl() { ...@@ -226,7 +225,7 @@ void MediaStreamRemoteVideoSource::StopSourceImpl() {
observer_.reset(); observer_.reset();
} }
rtc::VideoSinkInterface<cricket::VideoFrame>* rtc::VideoSinkInterface<webrtc::VideoFrame>*
MediaStreamRemoteVideoSource::SinkInterfaceForTest() { MediaStreamRemoteVideoSource::SinkInterfaceForTest() {
return delegate_.get(); return delegate_.get();
} }
......
...@@ -49,7 +49,7 @@ class CONTENT_EXPORT MediaStreamRemoteVideoSource ...@@ -49,7 +49,7 @@ class CONTENT_EXPORT MediaStreamRemoteVideoSource
// Used by tests to test that a frame can be received and that the // Used by tests to test that a frame can be received and that the
// MediaStreamRemoteVideoSource behaves as expected. // MediaStreamRemoteVideoSource behaves as expected.
rtc::VideoSinkInterface<cricket::VideoFrame>* SinkInterfaceForTest(); rtc::VideoSinkInterface<webrtc::VideoFrame>* SinkInterfaceForTest();
private: private:
void OnChanged(webrtc::MediaStreamTrackInterface::TrackState state); void OnChanged(webrtc::MediaStreamTrackInterface::TrackState state);
......
...@@ -18,7 +18,6 @@ ...@@ -18,7 +18,6 @@
#include "media/base/video_frame.h" #include "media/base/video_frame.h"
#include "testing/gtest/include/gtest/gtest.h" #include "testing/gtest/include/gtest/gtest.h"
#include "third_party/WebKit/public/web/WebHeap.h" #include "third_party/WebKit/public/web/WebHeap.h"
#include "third_party/webrtc/media/engine/webrtcvideoframe.h"
namespace content { namespace content {
...@@ -132,7 +131,7 @@ TEST_F(MediaStreamRemoteVideoSourceTest, StartTrack) { ...@@ -132,7 +131,7 @@ TEST_F(MediaStreamRemoteVideoSourceTest, StartTrack) {
buffer->SetToBlack(); buffer->SetToBlack();
source()->SinkInterfaceForTest()->OnFrame( source()->SinkInterfaceForTest()->OnFrame(
cricket::WebRtcVideoFrame(buffer, webrtc::kVideoRotation_0, 1000)); webrtc::VideoFrame(buffer, webrtc::kVideoRotation_0, 1000));
run_loop.Run(); run_loop.Run();
EXPECT_EQ(1, sink.number_of_frames()); EXPECT_EQ(1, sink.number_of_frames());
......
...@@ -64,9 +64,9 @@ class MockVideoTrackInterface : public VideoTrackInterface { ...@@ -64,9 +64,9 @@ class MockVideoTrackInterface : public VideoTrackInterface {
MOCK_METHOD1(set_enabled, bool(bool)); MOCK_METHOD1(set_enabled, bool(bool));
MOCK_METHOD1(set_state, bool(TrackState)); MOCK_METHOD1(set_state, bool(TrackState));
MOCK_METHOD2(AddOrUpdateSink, MOCK_METHOD2(AddOrUpdateSink,
void(rtc::VideoSinkInterface<cricket::VideoFrame>*, void(rtc::VideoSinkInterface<webrtc::VideoFrame>*,
const rtc::VideoSinkWants&)); const rtc::VideoSinkWants&));
MOCK_METHOD1(RemoveSink, void(rtc::VideoSinkInterface<cricket::VideoFrame>*)); MOCK_METHOD1(RemoveSink, void(rtc::VideoSinkInterface<webrtc::VideoFrame>*));
MOCK_CONST_METHOD0(GetSource, VideoTrackSourceInterface*()); MOCK_CONST_METHOD0(GetSource, VideoTrackSourceInterface*());
private: private:
......
...@@ -191,14 +191,14 @@ scoped_refptr<MockWebRtcVideoTrack> MockWebRtcVideoTrack::Create( ...@@ -191,14 +191,14 @@ scoped_refptr<MockWebRtcVideoTrack> MockWebRtcVideoTrack::Create(
} }
void MockWebRtcVideoTrack::AddOrUpdateSink( void MockWebRtcVideoTrack::AddOrUpdateSink(
rtc::VideoSinkInterface<cricket::VideoFrame>* sink, rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
const rtc::VideoSinkWants& wants) { const rtc::VideoSinkWants& wants) {
DCHECK(!sink_); DCHECK(!sink_);
sink_ = sink; sink_ = sink;
} }
void MockWebRtcVideoTrack::RemoveSink( void MockWebRtcVideoTrack::RemoveSink(
rtc::VideoSinkInterface<cricket::VideoFrame>* sink) { rtc::VideoSinkInterface<webrtc::VideoFrame>* sink) {
DCHECK(sink_ == sink); DCHECK(sink_ == sink);
sink_ = NULL; sink_ = NULL;
} }
......
...@@ -55,9 +55,9 @@ class MockWebRtcVideoTrack : public webrtc::VideoTrackInterface { ...@@ -55,9 +55,9 @@ class MockWebRtcVideoTrack : public webrtc::VideoTrackInterface {
static scoped_refptr<MockWebRtcVideoTrack> Create(const std::string& id); static scoped_refptr<MockWebRtcVideoTrack> Create(const std::string& id);
MockWebRtcVideoTrack(const std::string& id, MockWebRtcVideoTrack(const std::string& id,
webrtc::VideoTrackSourceInterface* source); webrtc::VideoTrackSourceInterface* source);
void AddOrUpdateSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink, void AddOrUpdateSink(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
const rtc::VideoSinkWants& wants) override; const rtc::VideoSinkWants& wants) override;
void RemoveSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink) override; void RemoveSink(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink) override;
webrtc::VideoTrackSourceInterface* GetSource() const override; webrtc::VideoTrackSourceInterface* GetSource() const override;
std::string kind() const override; std::string kind() const override;
...@@ -80,7 +80,7 @@ class MockWebRtcVideoTrack : public webrtc::VideoTrackInterface { ...@@ -80,7 +80,7 @@ class MockWebRtcVideoTrack : public webrtc::VideoTrackInterface {
bool enabled_; bool enabled_;
TrackState state_; TrackState state_;
ObserverSet observers_; ObserverSet observers_;
rtc::VideoSinkInterface<cricket::VideoFrame>* sink_; rtc::VideoSinkInterface<webrtc::VideoFrame>* sink_;
}; };
class MockMediaStream : public webrtc::MediaStreamInterface { class MockMediaStream : public webrtc::MediaStreamInterface {
......
...@@ -20,9 +20,7 @@ ...@@ -20,9 +20,7 @@
#include "third_party/libyuv/include/libyuv/convert_from.h" #include "third_party/libyuv/include/libyuv/convert_from.h"
#include "third_party/libyuv/include/libyuv/scale.h" #include "third_party/libyuv/include/libyuv/scale.h"
#include "third_party/skia/include/core/SkSurface.h" #include "third_party/skia/include/core/SkSurface.h"
#include "third_party/webrtc/common_video/include/video_frame_buffer.h"
#include "third_party/webrtc/common_video/rotation.h" #include "third_party/webrtc/common_video/rotation.h"
#include "third_party/webrtc/media/engine/webrtcvideoframe.h"
namespace content { namespace content {
...@@ -201,7 +199,7 @@ void WebRtcVideoCapturerAdapter::OnFrameCaptured( ...@@ -201,7 +199,7 @@ void WebRtcVideoCapturerAdapter::OnFrameCaptured(
// Return |frame| directly if it is texture backed, because there is no // Return |frame| directly if it is texture backed, because there is no
// cropping support for texture yet. See http://crbug/503653. // cropping support for texture yet. See http://crbug/503653.
if (frame->HasTextures()) { if (frame->HasTextures()) {
OnFrame(cricket::WebRtcVideoFrame( OnFrame(webrtc::VideoFrame(
new rtc::RefCountedObject<WebRtcVideoFrameAdapter>( new rtc::RefCountedObject<WebRtcVideoFrameAdapter>(
frame, base::Bind(&TextureFrameCopier::CopyTextureFrame, frame, base::Bind(&TextureFrameCopier::CopyTextureFrame,
texture_copier_)), texture_copier_)),
...@@ -230,7 +228,7 @@ void WebRtcVideoCapturerAdapter::OnFrameCaptured( ...@@ -230,7 +228,7 @@ void WebRtcVideoCapturerAdapter::OnFrameCaptured(
// If no scaling is needed, return a wrapped version of |frame| directly. // If no scaling is needed, return a wrapped version of |frame| directly.
if (video_frame->natural_size() == video_frame->visible_rect().size()) { if (video_frame->natural_size() == video_frame->visible_rect().size()) {
OnFrame(cricket::WebRtcVideoFrame( OnFrame(webrtc::VideoFrame(
new rtc::RefCountedObject<WebRtcVideoFrameAdapter>( new rtc::RefCountedObject<WebRtcVideoFrameAdapter>(
video_frame, video_frame,
WebRtcVideoFrameAdapter::CopyTextureFrameCallback()), WebRtcVideoFrameAdapter::CopyTextureFrameCallback()),
...@@ -260,7 +258,7 @@ void WebRtcVideoCapturerAdapter::OnFrameCaptured( ...@@ -260,7 +258,7 @@ void WebRtcVideoCapturerAdapter::OnFrameCaptured(
scaled_frame->stride(media::VideoFrame::kVPlane), scaled_frame->stride(media::VideoFrame::kVPlane),
adapted_width, adapted_height, libyuv::kFilterBilinear); adapted_width, adapted_height, libyuv::kFilterBilinear);
OnFrame(cricket::WebRtcVideoFrame( OnFrame(webrtc::VideoFrame(
new rtc::RefCountedObject<WebRtcVideoFrameAdapter>( new rtc::RefCountedObject<WebRtcVideoFrameAdapter>(
scaled_frame, scaled_frame,
WebRtcVideoFrameAdapter::CopyTextureFrameCallback()), WebRtcVideoFrameAdapter::CopyTextureFrameCallback()),
......
...@@ -19,7 +19,7 @@ static void ReleaseMailboxCB(const gpu::SyncToken& sync_token) {} ...@@ -19,7 +19,7 @@ static void ReleaseMailboxCB(const gpu::SyncToken& sync_token) {}
namespace content { namespace content {
class WebRtcVideoCapturerAdapterTest class WebRtcVideoCapturerAdapterTest
: public rtc::VideoSinkInterface<cricket::VideoFrame>, : public rtc::VideoSinkInterface<webrtc::VideoFrame>,
public ::testing::Test { public ::testing::Test {
public: public:
WebRtcVideoCapturerAdapterTest() WebRtcVideoCapturerAdapterTest()
...@@ -77,7 +77,7 @@ class WebRtcVideoCapturerAdapterTest ...@@ -77,7 +77,7 @@ class WebRtcVideoCapturerAdapterTest
} }
// rtc::VideoSinkInterface // rtc::VideoSinkInterface
void OnFrame(const cricket::VideoFrame& frame) override { void OnFrame(const webrtc::VideoFrame& frame) override {
output_frame_ = frame; output_frame_ = frame;
output_frame_width_ = frame.width(); output_frame_width_ = frame.width();
output_frame_height_ = frame.height(); output_frame_height_ = frame.height();
...@@ -88,7 +88,8 @@ class WebRtcVideoCapturerAdapterTest ...@@ -88,7 +88,8 @@ class WebRtcVideoCapturerAdapterTest
const ChildProcess child_process_; const ChildProcess child_process_;
WebRtcVideoCapturerAdapter adapter_; WebRtcVideoCapturerAdapter adapter_;
cricket::VideoFrame output_frame_; // TODO(nisse): Default constructor is deprecated. Use std::optional?
webrtc::VideoFrame output_frame_;
int output_frame_width_; int output_frame_width_;
int output_frame_height_; int output_frame_height_;
}; };
......
...@@ -22,7 +22,6 @@ ...@@ -22,7 +22,6 @@
#include "remoting/protocol/video_renderer.h" #include "remoting/protocol/video_renderer.h"
#include "remoting/protocol/webrtc_transport.h" #include "remoting/protocol/webrtc_transport.h"
#include "third_party/libyuv/include/libyuv/convert_from.h" #include "third_party/libyuv/include/libyuv/convert_from.h"
#include "third_party/webrtc/media/base/videoframe.h"
#include "third_party/webrtc/modules/desktop_capture/desktop_frame.h" #include "third_party/webrtc/modules/desktop_capture/desktop_frame.h"
namespace remoting { namespace remoting {
...@@ -96,7 +95,7 @@ void WebrtcVideoRendererAdapter::SetVideoStatsChannel( ...@@ -96,7 +95,7 @@ void WebrtcVideoRendererAdapter::SetVideoStatsChannel(
video_stats_dispatcher_->Init(std::move(message_pipe), this); video_stats_dispatcher_->Init(std::move(message_pipe), this);
} }
void WebrtcVideoRendererAdapter::OnFrame(const cricket::VideoFrame& frame) { void WebrtcVideoRendererAdapter::OnFrame(const webrtc::VideoFrame& frame) {
if (static_cast<uint64_t>(frame.timestamp_us()) >= rtc::TimeMicros()) { if (static_cast<uint64_t>(frame.timestamp_us()) >= rtc::TimeMicros()) {
// The host sets playout delay to 0, so all incoming frames are expected to // The host sets playout delay to 0, so all incoming frames are expected to
// be rendered as so as they are received. // be rendered as so as they are received.
......
...@@ -35,7 +35,7 @@ struct ClientFrameStats; ...@@ -35,7 +35,7 @@ struct ClientFrameStats;
struct HostFrameStats; struct HostFrameStats;
class WebrtcVideoRendererAdapter class WebrtcVideoRendererAdapter
: public rtc::VideoSinkInterface<cricket::VideoFrame>, : public rtc::VideoSinkInterface<webrtc::VideoFrame>,
public VideoStatsStub, public VideoStatsStub,
public ClientVideoStatsDispatcher::EventHandler { public ClientVideoStatsDispatcher::EventHandler {
public: public:
...@@ -49,7 +49,7 @@ class WebrtcVideoRendererAdapter ...@@ -49,7 +49,7 @@ class WebrtcVideoRendererAdapter
void SetVideoStatsChannel(std::unique_ptr<MessagePipe> message_pipe); void SetVideoStatsChannel(std::unique_ptr<MessagePipe> message_pipe);
// rtc::VideoSinkInterface implementation. // rtc::VideoSinkInterface implementation.
void OnFrame(const cricket::VideoFrame& frame) override; void OnFrame(const webrtc::VideoFrame& frame) override;
private: private:
// VideoStatsStub interface. // VideoStatsStub interface.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment