Commit 1a150ace authored by Friedrich Horschig's avatar Friedrich Horschig Committed by Commit Bot

[Flaky][Mac] Disable BrowserViewTests on Mac only

This disables all BrowserViewTests that haven't been disabled yet.
Because these failures have always been Mac-only, reenable one disabled
tests for non-Mac platforms.

TBR=weili@chromium.org, bsep@chromium.org

Bug: 875707
Change-Id: Ie0a24b706669d07577bf2413a61bd959d70950cc
Reviewed-on: https://chromium-review.googlesource.com/1180975
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarFriedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584409}
parent 3ad6465f
......@@ -56,9 +56,16 @@ IN_PROC_BROWSER_TEST_F(BrowserViewTest, MAYBE_FullscreenClearsFocus) {
EXPECT_FALSE(location_bar_view->Contains(focus_manager->GetFocusedView()));
}
#if defined(OS_MACOSX)
// Frequently hits "Check failed: browser_view_->IsTabStripVisible()". See
// http://crbug.com/875707 for details.
#define MAYBE_BrowserFullscreenShowTopView DISABLED_BrowserFullscreenShowTopView
#else
#define MAYBE_BrowserFullscreenShowTopView BrowserFullscreenShowTopView
#endif
// Test whether the top view including toolbar and tab strip shows up or hides
// correctly in browser fullscreen mode.
IN_PROC_BROWSER_TEST_F(BrowserViewTest, BrowserFullscreenShowTopView) {
IN_PROC_BROWSER_TEST_F(BrowserViewTest, MAYBE_BrowserFullscreenShowTopView) {
BrowserView* browser_view = static_cast<BrowserView*>(browser()->window());
#if defined(OS_MACOSX)
// First, set the preference to true so we expect to see the top view in
......@@ -121,9 +128,16 @@ IN_PROC_BROWSER_TEST_F(BrowserViewTest, BrowserFullscreenShowTopView) {
EXPECT_TRUE(browser_view->IsTabStripVisible());
}
#if defined(OS_MACOSX)
// Frequently hits "Check failed: browser_view_->IsTabStripVisible()". See
// http://crbug.com/875707 for details.
#define MAYBE_TabFullscreenShowTopView DISABLED_TabFullscreenShowTopView
#else
#define MAYBE_TabFullscreenShowTopView TabFullscreenShowTopView
#endif
// Test whether the top view including toolbar and tab strip appears or hides
// correctly in tab fullscreen mode.
IN_PROC_BROWSER_TEST_F(BrowserViewTest, DISABLED_TabFullscreenShowTopView) {
IN_PROC_BROWSER_TEST_F(BrowserViewTest, MAYBE_TabFullscreenShowTopView) {
BrowserView* browser_view = static_cast<BrowserView*>(browser()->window());
// The top view should always show up in regular mode.
......@@ -147,8 +161,15 @@ IN_PROC_BROWSER_TEST_F(BrowserViewTest, DISABLED_TabFullscreenShowTopView) {
EXPECT_TRUE(browser_view->IsTabStripVisible());
}
#if defined(OS_MACOSX)
// Frequently hits "Check failed: browser_view_->IsTabStripVisible()". See
// http://crbug.com/875707 for details.
#define MAYBE_FullscreenShowBookmarkBar DISABLED_FullscreenShowBookmarkBar
#else
#define MAYBE_FullscreenShowBookmarkBar FullscreenShowBookmarkBar
#endif
// Test whether bookmark bar shows up or hides correctly for fullscreen modes.
IN_PROC_BROWSER_TEST_F(BrowserViewTest, FullscreenShowBookmarkBar) {
IN_PROC_BROWSER_TEST_F(BrowserViewTest, MAYBE_FullscreenShowBookmarkBar) {
BrowserView* browser_view = static_cast<BrowserView*>(browser()->window());
// If the bookmark bar is not showing, enable showing it so that we can check
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment