Commit 1a45c914 authored by timloh@chromium.org's avatar timloh@chromium.org

Revert of GN: Specify grit generated output paths to be the same as gyp's....

Revert of GN: Specify grit generated output paths to be the same as gyp's. (patchset #1 of https://codereview.chromium.org/454253004/)

Reason for revert:
Broke GN compile and try jobs

http://build.chromium.org/p/chromium.webkit/builders/Linux%20GN

Original issue's description:
> GN: Specify grit generated output paths to be the same as gyp's.
> 
> BUG=401588
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289149

TBR=brettw@chromium.org,jamescook@chromium.org,yoz@chromium.org,thestig@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=401588

Review URL: https://codereview.chromium.org/461213003

Cr-Commit-Position: refs/heads/master@{#289209}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289209 0039d316-1c4b-4281-b951-d872f2087c98
parent b4a50279
...@@ -8,7 +8,6 @@ import("//tools/grit/grit_rule.gni") ...@@ -8,7 +8,6 @@ import("//tools/grit/grit_rule.gni")
# (generate_generated_resources action) # (generate_generated_resources action)
grit("generated_resources") { grit("generated_resources") {
source = "generated_resources.grd" source = "generated_resources.grd"
output_dir = "$root_gen_dir/chrome"
outputs = [ outputs = [
"grit/generated_resources.h", "grit/generated_resources.h",
"generated_resources_am.pak", "generated_resources_am.pak",
...@@ -75,8 +74,8 @@ action("make_generated_resources_map") { ...@@ -75,8 +74,8 @@ action("make_generated_resources_map") {
script = "//chrome/browser/metrics/variations/generate_resources_map.py" script = "//chrome/browser/metrics/variations/generate_resources_map.py"
inputs = [ "$root_gen_dir/chrome/grit/generated_resources.h" ] inputs = [ "$target_gen_dir/grit/generated_resources.h" ]
outputs = [ "$root_gen_dir/chrome/generated_resources_map.cc" ] outputs = [ "$target_gen_dir/generated_resources_map.cc" ]
args = rebase_path(inputs, root_build_dir) + args = rebase_path(inputs, root_build_dir) +
rebase_path(outputs, root_build_dir) rebase_path(outputs, root_build_dir)
...@@ -95,7 +94,6 @@ source_set("generated_resources_map") { ...@@ -95,7 +94,6 @@ source_set("generated_resources_map") {
# (generate_google_chrome_strings action) # (generate_google_chrome_strings action)
grit("google_chrome_strings") { grit("google_chrome_strings") {
source = "google_chrome_strings.grd" source = "google_chrome_strings.grd"
output_dir = "$root_gen_dir/chrome"
outputs = [ outputs = [
"grit/google_chrome_strings.h", "grit/google_chrome_strings.h",
"google_chrome_strings_am.pak", "google_chrome_strings_am.pak",
...@@ -159,7 +157,6 @@ grit("google_chrome_strings") { ...@@ -159,7 +157,6 @@ grit("google_chrome_strings") {
# (generate_chromium_strings action) # (generate_chromium_strings action)
grit("chromium_strings") { grit("chromium_strings") {
source = "chromium_strings.grd" source = "chromium_strings.grd"
output_dir = "$root_gen_dir/chrome"
outputs = [ outputs = [
"grit/chromium_strings.h", "grit/chromium_strings.h",
"chromium_strings_am.pak", "chromium_strings_am.pak",
......
...@@ -8,7 +8,6 @@ import("//tools/grit/grit_rule.gni") ...@@ -8,7 +8,6 @@ import("//tools/grit/grit_rule.gni")
# (generate_locale_settings action) # (generate_locale_settings action)
grit("locale_settings") { grit("locale_settings") {
source = "locale_settings.grd" source = "locale_settings.grd"
output_dir = "$root_gen_dir/chrome"
outputs = [ outputs = [
"grit/locale_settings.h", "grit/locale_settings.h",
"locale_settings_am.pak", "locale_settings_am.pak",
......
...@@ -614,7 +614,6 @@ static_library("browser") { ...@@ -614,7 +614,6 @@ static_library("browser") {
# (generate_browser_resources action) # (generate_browser_resources action)
grit("resources") { grit("resources") {
source = "browser_resources.grd" source = "browser_resources.grd"
output_dir = "$root_gen_dir/chrome"
outputs = [ outputs = [
"grit/browser_resources.h", "grit/browser_resources.h",
"browser_resources.pak", "browser_resources.pak",
......
...@@ -14,7 +14,6 @@ gypi_values = exec_script( ...@@ -14,7 +14,6 @@ gypi_values = exec_script(
# (generate_common_resources action) # (generate_common_resources action)
grit("resources") { grit("resources") {
source = "common_resources.grd" source = "common_resources.grd"
output_dir = "$root_gen_dir/chrome"
outputs = [ outputs = [
"grit/common_resources.h", "grit/common_resources.h",
"common_resources.pak", "common_resources.pak",
...@@ -25,7 +24,6 @@ grit("resources") { ...@@ -25,7 +24,6 @@ grit("resources") {
# (generate_extensions_api_resources action) # (generate_extensions_api_resources action)
grit("extensions_api_resources") { grit("extensions_api_resources") {
source = "extensions_api_resources.grd" source = "extensions_api_resources.grd"
output_dir = "$root_gen_dir/chrome"
outputs = [ outputs = [
"grit/extensions_api_resources.h", "grit/extensions_api_resources.h",
"extensions_api_resources.pak", "extensions_api_resources.pak",
......
...@@ -15,7 +15,6 @@ gypi_values = exec_script( ...@@ -15,7 +15,6 @@ gypi_values = exec_script(
# (generate_renderer_resources action) # (generate_renderer_resources action)
grit("resources") { grit("resources") {
source = "resources/renderer_resources.grd" source = "resources/renderer_resources.grd"
output_dir = "$root_gen_dir/chrome"
outputs = [ outputs = [
"grit/renderer_resources.h", "grit/renderer_resources.h",
"renderer_resources_100_percent.pak", "renderer_resources_100_percent.pak",
......
...@@ -86,7 +86,7 @@ repack("shell_and_test_pak") { ...@@ -86,7 +86,7 @@ repack("shell_and_test_pak") {
"$root_gen_dir/chrome/common/extensions_api_resources.pak", "$root_gen_dir/chrome/common/extensions_api_resources.pak",
# TODO(jamescook): Extract the extension/app related resources # TODO(jamescook): Extract the extension/app related resources
# from generated_resources_en-US.pak. http://crbug.com/397250 # from generated_resources_en-US.pak. http://crbug.com/397250
"$root_gen_dir/chrome/generated_resources_en-US.pak", "$root_gen_dir/chrome/app/generated_resources_en-US.pak",
"$root_gen_dir/chrome/renderer/renderer_resources_100_percent.pak", "$root_gen_dir/chrome/renderer/renderer_resources_100_percent.pak",
"$root_gen_dir/content/content_resources.pak", "$root_gen_dir/content/content_resources.pak",
"$root_gen_dir/content/shell/shell_resources.pak", "$root_gen_dir/content/shell/shell_resources.pak",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment