Commit 1a6b13d2 authored by Henrik Boström's avatar Henrik Boström Committed by Commit Bot

Reland "[Perfect Negotiation] Re-enable temporarily disabled WPTs."

This reverts commit 864e565b.

Reason for revert: Not the culprit of the bot failures

Original change's description:
> Revert "[Perfect Negotiation] Re-enable temporarily disabled WPTs."
>
> This reverts commit 154433da.
>
> Reason for revert: linux-trusty-rel build and external blink web_driver tests are failing, and that's a possible root cause. See: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/15138
>
> Original change's description:
> > [Perfect Negotiation] Re-enable temporarily disabled WPTs.
> >
> > Now that https://webrtc-review.googlesource.com/c/src/+/180620 has
> > rolled into chromium, we can re-enable the disabled tests and update
> > the expectations that more tests are passing.
> >
> > Follow-up CLs will make us pass even more tests.
> >
> > Bug: chromium:1060083
> > Change-Id: Ia1e1432746293fa395e5bda72e163f223f316b7f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377707
> > Reviewed-by: Harald Alvestrand <hta@chromium.org>
> > Commit-Queue: Henrik Boström <hbos@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#801716}
>
> TBR=hta@chromium.org,hbos@chromium.org
>
> Change-Id: I3250545b0fff846a8c4c3a9352f5a342ae613599
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1060083
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377872
> Reviewed-by: Amr Aboelkher <amraboelkher@google.com>
> Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
> Cr-Commit-Position: refs/heads/master@{#801762}

TBR=hta@chromium.org,hbos@chromium.org,amraboelkher@google.com

# Skipping bots on reland because the revert was by mistake and there
# are CL dependencies.
NOTRY=True

Bug: chromium:1060083
Change-Id: Ic542d9d2a6051de05073b59a21a2dee7ae81eafc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376814Reviewed-by: default avatarHenrik Boström <hbos@chromium.org>
Reviewed-by: default avatarAmr Aboelkher <amraboelkher@google.com>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801779}
parent d3edefeb
......@@ -5316,9 +5316,6 @@ crbug.com/986018 fast/scroll-snap/snaps-for-different-key-granularity.html [ Fai
# This test is not intended to pass on Plan B.
crbug.com/740501 virtual/webrtc-wpt-plan-b/external/wpt/webrtc/RTCPeerConnection-onnegotiationneeded.html [ Pass Failure Timeout ]
# Temporarily disable to unblock a WebRTC CL that makes more tests pass.
crbug.com/1060083 external/wpt/webrtc/RTCPeerConnection-onnegotiationneeded.html [ Pass Failure ]
crbug.com/1060083 external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-rollback.html [ Pass Failure ]
crbug.com/910979 http/tests/html/validation-bubble-oopif-clip.html [ Failure Pass ]
......
......@@ -6,9 +6,9 @@ PASS Calling addTransceiver() twice should fire negotiationneeded event once
PASS Calling both addTransceiver() and createDataChannel() should fire negotiationneeded event once
PASS negotiationneeded event should not fire if signaling state is not stable
FAIL negotiationneeded event should fire only after signaling state goes back to stable after setRemoteDescription assert_false: negotiationneeded should not fire until the next iteration of the event loop after SRD success expected false got true
FAIL negotiationneeded event should fire only after signaling state goes back to stable after setLocalDescription assert_false: negotiationneeded should not fire until the next iteration of the event loop after SLD success expected false got true
FAIL negotiationneeded event should fire only after signalingstatechange event fires from setRemoteDescription assert_false: negotiationneeded should not fire before signalingstatechange fires expected false got true
FAIL negotiationneeded event should fire only after signalingstatechange event fires from setLocalDescription assert_false: negotiationneeded should not fire until the next iteration of the event loop after returning to stable expected false got true
PASS negotiationneeded event should fire only after signaling state goes back to stable after setLocalDescription
PASS negotiationneeded event should fire only after signalingstatechange event fires from setRemoteDescription
PASS negotiationneeded event should fire only after signalingstatechange event fires from setLocalDescription
PASS addTrack should cause negotiationneeded to fire
PASS removeTrack should cause negotiationneeded to fire on the caller
PASS removeTrack should cause negotiationneeded to fire on the callee
......
This is a testharness.js-based test.
PASS setRemoteDescription(rollback) in have-remote-offer state should revert to stable state
PASS setRemoteDescription(rollback) from stable state should reject with InvalidStateError
PASS setRemoteDescription(rollback) should ignore invalid sdp content and succeed
PASS local offer created before setRemoteDescription(remote offer) then rollback should still be usable
PASS local offer created before setRemoteDescription(remote offer) with different transceiver level assignments then rollback should still be usable
PASS rollback of a remote offer should remove a transceiver
PASS rollback of a remote offer should remove touched transceiver
PASS rollback of a remote offer should keep a transceiver
PASS rollback of a remote offer should keep a transceiver created by addtrack
PASS rollback of a remote offer should keep a transceiver without tracks
PASS explicit rollback of local offer should remove transceivers and transport
FAIL when using addTransceiver, implicit rollback of a local offer should visit stable state, but not fire negotiationneeded until we settle in stable assert_true: There should be no negotiationneeded event right now expected true got false
PASS when using addTrack, implicit rollback of a local offer should visit stable state, but not fire negotiationneeded
PASS rollback of a remote offer to negotiated stable state should enable applying of a local offer
PASS rollback of a local offer to negotiated stable state should enable applying of a remote offer
PASS rollback a local offer with audio direction change to negotiated stable state and then add video receiver
PASS two transceivers with same mids
PASS onremovetrack fires during remote rollback
PASS rollback of a remote offer with stream changes
PASS removeTrack() with a sender being rolled back does not crash or throw
PASS Implicit rollback with only a datachannel works
Harness: the test ran to completion.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment