[Extensions] Disallow ExtensionService includes from //extensions

//extensions should not depend on //chrome at all. Currently, there are
exceptions for tests, but these shouldn't really be allowed either.
Remove extension_service.h from the list of test-allowed includes, and
move the runtime_apitest to the chrome layer. This test fundamentally
relies on Chrome concepts, so doesn't belong at the //extensions layer.

Bug: 773004
Change-Id: I33933ef42cc1ec1e456adb557cb83a26292d6564
Reviewed-on: https://chromium-review.googlesource.com/857259Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530014}

chrome/test/BUILD.gn

@@ -1162,6 +1162,7 @@ test("browser_tests") {
         "../browser/extensions/api/processes/processes_apitest.cc",
         "../browser/extensions/api/proxy/proxy_apitest.cc",
         "../browser/extensions/api/resources_private/resources_private_apitest.cc",
+        "../browser/extensions/api/runtime/runtime_apitest.cc",
         "../browser/extensions/api/screenlock_private/screenlock_private_apitest.cc",
         "../browser/extensions/api/sessions/sessions_apitest.cc",
         "../browser/extensions/api/settings_overrides/settings_overrides_browsertest.cc",

extensions/BUILD.gn

@@ -258,7 +258,6 @@ source_set("chrome_extensions_browsertests") {
     "browser/api/bluetooth/bluetooth_apitest.cc",
     "browser/api/bluetooth/bluetooth_private_apitest.cc",
     "browser/api/cast_channel/cast_channel_apitest.cc",
-    "browser/api/runtime/runtime_apitest.cc",
     "browser/api/serial/serial_apitest.cc",
     "browser/api/usb/usb_manual_apitest.cc",
     "browser/app_window/app_window_browsertest.cc",

extensions/browser/DEPS

@@ -49,7 +49,6 @@ specific_include_rules = {
     "+chrome/browser/extensions/api/permissions/permissions_api.h",
     "+chrome/browser/extensions/extension_apitest.h",
     "+chrome/browser/extensions/extension_function_test_utils.h",
-    "+chrome/browser/extensions/extension_service.h",
     "+chrome/browser/extensions/extension_service_test_base.h",
     "+chrome/browser/extensions/test_extension_dir.h",
     "+chrome/browser/ui/browser.h",

extensions/browser/api/bluetooth/bluetooth_apitest.cc

@@ -8,7 +8,6 @@
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_function_test_utils.h"
-#include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "device/bluetooth/bluetooth_adapter.h"

extensions/browser/api/cast_channel/cast_channel_apitest.cc

@@ -10,7 +10,6 @@
 #include "build/build_config.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_function_test_utils.h"
-#include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/ui/browser.h"
 #include "components/cast_channel/cast_socket.h"
 #include "components/cast_channel/cast_socket_service.h"