Commit 1a8158b4 authored by Matthew Cary's avatar Matthew Cary Committed by Commit Bot

trace_event: Clean up shared memory comments.

The shared memory parts of ProcessMemoryDump apply to both legacy
base::SharedMemory as well as the new *SharedMemoryRegion and
*SharedMemoryMapping api. This change cleans up the comments but
does not change any code.

Bug: 795291
Change-Id: I3b88445ad04fe3b94996e5ff895110c5527df1cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567665
Commit-Queue: Antoine Labour <piman@chromium.org>
Auto-Submit: Matthew Cary <mattcary@chromium.org>
Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
Reviewed-by: default avatarAlex Ilin <alexilin@chromium.org>
Reviewed-by: default avatarssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652577}
parent 6e1bf270
......@@ -28,7 +28,6 @@
namespace base {
class SharedMemory;
class UnguessableToken;
namespace trace_event {
......@@ -177,16 +176,15 @@ class BASE_EXPORT ProcessMemoryDump {
const MemoryAllocatorDumpGuid& target,
int importance);
// Creates ownership edges for memory backed by base::SharedMemory. Handles
// the case of cross process sharing and importnace of ownership for the case
// with and without the base::SharedMemory dump provider. The new version
// should just use global dumps created by SharedMemoryTracker and this
// function handles the transition until we get SharedMemory IDs through mojo
// channel crbug.com/713763. The weak version creates a weak global dump.
// Creates ownership edges for shared memory. Handles the case of cross
// process sharing and importance of ownership for the case with and without
// the shared memory dump provider. This handles both shared memory from both
// legacy base::SharedMemory as well as current base::SharedMemoryMapping. The
// weak version creates a weak global dump.
// |client_local_dump_guid| The guid of the local dump created by the client
// of base::SharedMemory.
// |shared_memory_guid| The ID of the base::SharedMemory that is assigned
// globally, used to create global dump edges in the new model.
// |shared_memory_guid| The ID of the shared memory that is assigned globally,
// used to create global dump edges in the new model.
// |importance| Importance of the global dump edges to say if the current
// process owns the memory segment.
void CreateSharedMemoryOwnershipEdge(
......
......@@ -20,8 +20,6 @@
#include "gpu/command_buffer/common/cmd_buffer_common.h"
#include "gpu/command_buffer/service/memory_tracking.h"
using ::base::SharedMemory;
namespace gpu {
TransferBufferManager::TransferBufferManager(MemoryTracker* memory_tracker)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment