Skip to content

GitLab

T
tangled
Commit 1a92a752 authored by Philip Jägenstedt's avatar Philip Jägenstedt Committed by Commit Bot
Browse files
Options

Switch a `promise_test` to a plain synchronous `test` 

This adapts to "Reject non-thenable values" upstream:
https://github.com/web-platform-tests/wpt/pull/12898

This is blocking updating LayoutTests/resources/testharness.js.

Bug: 892613
Change-Id: Ifbc91824c0a5687a74cc6f16e02457da60dc4e85
Reviewed-on: https://chromium-review.googlesource.com/c/1264585
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: default avatarHenrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597521}
parent 562e1872
Hide whitespace changes
Inline Side-by-side
Showing with 7 additions and 7 deletions
third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-Id.html
View file @ 1a92a752
...@@ -7,17 +7,17 @@ ...@@ -7,17 +7,17 @@
</head> </head>
<body> <body>
<script> <script>
promise_test(function() { test(t => {
var pc = new RTCPeerConnection(); const pc = new RTCPeerConnection();
t.add_cleanup(() => { pc.close(); });
assert_equals(typeof pc.id, 'string'); assert_equals(typeof pc.id, 'string');
return function(){};
}, 'RTCPeerConnection.id is a string.'); }, 'RTCPeerConnection.id is a string.');
promise_test(function() { test(t => {
var pc1 = new RTCPeerConnection(); const pc1 = new RTCPeerConnection();
var pc2 = new RTCPeerConnection(); const pc2 = new RTCPeerConnection();
t.add_cleanup(() => { pc1.close(); pc2.close() });
assert_not_equals(pc1.id, pc2.id); assert_not_equals(pc1.id, pc2.id);
return function(){};
}, 'RTCPeerConnection.id is unique between RTCPeerConnection objects.'); }, 'RTCPeerConnection.id is unique between RTCPeerConnection objects.');
</script> </script>
</body> </body>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment