Commit 1ac832ca authored by Noel Gordon's avatar Noel Gordon Committed by Commit Bot

[js-code-coverage] Update QuickView tests to optionally use $i18n{} text

CL:2559234 introduced changes to disable $i18n{} JS template replacement
when the --devtools-code-coverage command line flag is enabled, and only
for the ChromeOS Files app extension while in-test.

Update the files app QuickView integration tests to work with or without
the --devtools-code-coverage flag. Add helper i18nQuickViewLabelText for
extracting the expected QuickView item text (JS code coverage flag on or
flag off).

Minor: update getQuickViewMetadataBoxField with hidden option to support
callers wanting to check that a metadata box field is hidden. Also, some
changes for uniformity in "Check: the thing should happen" comments.

	--devtools-code-coverage

Test: browser_tests --gtest_filter="QuickView/FilesApp*"
Test: browser_tests --gtest_filter="QuickView/FilesApp*"
Bug: 1152612
Change-Id: Ie59f11d85038d91e4519551b144ea1f51f555533
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560017Reviewed-by: default avatarAlex Danilo <adanilo@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831196}
parent 8e244431
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment