Commit 1ad99445 authored by Javier Ernesto Flores Robles's avatar Javier Ernesto Flores Robles Committed by Chromium LUCI CQ

[iOS][CredentialProvider] Add a singular title for suggested passwords

Fixed: 1100887
Change-Id: Ib7a1ed5bbdf003e5311ab244730c8411f6b5f4e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584682
Auto-Submit: Javier Flores <javierrobles@chromium.org>
Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
Commit-Queue: Javier Flores <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836651}
parent e49a7454
......@@ -36,6 +36,7 @@
<string>IDS_IOS_CREDENTIAL_PROVIDER_SET_UP_SCREENLOCK_TITLE</string>
<string>IDS_IOS_CREDENTIAL_PROVIDER_SET_UP_SCREENLOCK_LEARN_HOW</string>
<string>IDS_IOS_CREDENTIAL_PROVIDER_SHOW_DETAILS_ACCESSIBILITY_LABEL</string>
<string>IDS_IOS_CREDENTIAL_PROVIDER_SUGGESTED_PASSWORD</string>
<string>IDS_IOS_CREDENTIAL_PROVIDER_SUGGESTED_PASSWORDS</string>
<string>IDS_IOS_CREDENTIAL_PROVIDER_OK</string>
</array>
......
......@@ -227,6 +227,9 @@ all other OS specific variables will be false.
<message name="IDS_IOS_CREDENTIAL_PROVIDER_SHOW_DETAILS_ACCESSIBILITY_LABEL" desc="Used as the accessibility label read by screen readers for a show details button." meaning="[iOS only][CHAR_LIMIT=30]">
Show Details
</message>
<message name="IDS_IOS_CREDENTIAL_PROVIDER_SUGGESTED_PASSWORD" desc="Header for table section for suggested passwords" meaning="Header of table section showing the password most likely to be selected by user [CHAR_LIMIT=30]">
Suggested Password
</message>
<message name="IDS_IOS_CREDENTIAL_PROVIDER_SUGGESTED_PASSWORDS" desc="Header for table section for suggested passwords" meaning="Header of table section showing passwords most likely to be selected by user [CHAR_LIMIT=30]">
Suggested Passwords
</message>
......
......@@ -133,8 +133,15 @@ const CGFloat kHeaderHeight = 70;
return NSLocalizedString(@"IDS_IOS_CREDENTIAL_PROVIDER_NO_SEARCH_RESULTS",
@"No search results found");
} else if ([self isSuggestedPasswordSection:section]) {
return NSLocalizedString(@"IDS_IOS_CREDENTIAL_PROVIDER_SUGGESTED_PASSWORDS",
@"Suggested Passwords");
if (self.suggestedPasswords.count > 1) {
return NSLocalizedString(
@"IDS_IOS_CREDENTIAL_PROVIDER_SUGGESTED_PASSWORDS",
@"Suggested Passwords");
} else {
return NSLocalizedString(
@"IDS_IOS_CREDENTIAL_PROVIDER_SUGGESTED_PASSWORD",
@"Suggested Password");
}
} else {
return NSLocalizedString(@"IDS_IOS_CREDENTIAL_PROVIDER_ALL_PASSWORDS",
@"All Passwords");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment