Commit 1b01b443 authored by Eugene But's avatar Eugene But Committed by Commit Bot

Remove IsRefreshLocationBarEnabled function.

This function always returns true, so the result was inclined in
toolbar_egtest.mm. EG2 Tests can not import ios/chrome/browser/ui/util/ui_util.h
(which declares IsRefreshLocationBarEnabled), so the function had to
be removed.

Bug: 884723
Change-Id: I7ab40c5016ca2b17c95d4fd6294df67cdcc55d81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642111Reviewed-by: default avatarMark Cogan <marq@chromium.org>
Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666344}
parent ad8447ee
...@@ -209,11 +209,9 @@ using chrome_test_util::SystemSelectionCalloutCopyButton; ...@@ -209,11 +209,9 @@ using chrome_test_util::SystemSelectionCalloutCopyButton;
// Verifies that copying and pasting a URL includes the hidden protocol prefix. // Verifies that copying and pasting a URL includes the hidden protocol prefix.
- (void)testCopyPasteURL { - (void)testCopyPasteURL {
if (IsRefreshLocationBarEnabled()) { // TODO(crbug.com/834345): Enable this test when long press on the steady
// TODO(crbug.com/834345): Enable this test when long press on the steady // location bar is supported.
// location bar is supported. EARL_GREY_TEST_SKIPPED(@"Test not supported yet in UI Refresh.");
EARL_GREY_TEST_SKIPPED(@"Test not supported yet in UI Refresh.");
}
// Clear generalPasteboard before and after the test. // Clear generalPasteboard before and after the test.
[UIPasteboard generalPasteboard].string = @""; [UIPasteboard generalPasteboard].string = @"";
......
...@@ -43,10 +43,6 @@ bool IsIPhoneX(); ...@@ -43,10 +43,6 @@ bool IsIPhoneX();
// in tab switcher when the last incognito tab is closed. // in tab switcher when the last incognito tab is closed.
bool IsClosingLastIncognitoTabEnabled(); bool IsClosingLastIncognitoTabEnabled();
// Returns whether the UI Refresh Location Bar will be used.
// TODO (crbug.com/884723): Remove all use of this flag.
bool IsRefreshLocationBarEnabled();
// Returns the approximate corner radius of the current device. // Returns the approximate corner radius of the current device.
CGFloat DeviceCornerRadius(); CGFloat DeviceCornerRadius();
......
...@@ -64,10 +64,6 @@ bool IsClosingLastIncognitoTabEnabled() { ...@@ -64,10 +64,6 @@ bool IsClosingLastIncognitoTabEnabled() {
return base::FeatureList::IsEnabled(kClosingLastIncognitoTab); return base::FeatureList::IsEnabled(kClosingLastIncognitoTab);
} }
bool IsRefreshLocationBarEnabled() {
return true;
}
CGFloat DeviceCornerRadius() { CGFloat DeviceCornerRadius() {
return IsIPhoneX() ? 40.0 : 0.0; return IsIPhoneX() ? 40.0 : 0.0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment