Commit 1b0c8408 authored by Changhao Han's avatar Changhao Han Committed by Commit Bot

Manually remove Grid-related layout test logics

Currently we're enabling CSS Grid experiment by default, which creates
small differences in layout test expectations. Since Grid feature is
still experimental, we will postpone updaing the expectations and
instead skip Grid-related logic in these two tests for now.

This change will unblock the frontend change: https://crrev.com/c/2416525

Bug: chromium:1047356
Change-Id: Ic0a26b17b09d13889ad0bcfafa6879b21089c2da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418315
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: default avatarAlex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808785}
parent 8315ba19
......@@ -22,6 +22,12 @@
var message = messages[i];
if (message.startsWith('backend'))
continue;
// Manually remove "Grid" because CSS Grid is still experimental but enabled by default
// see: https://crrev.com/c/2416525
// TODO: remove this and update test expectations once CSS Grid is non-experimental
if (message.includes('setShowGridOverlays')) {
continue;
}
message = message.replace(/"id":\d+,/, '"id":<number>,');
TestRunner.addResult(message);
}
......
......@@ -5,7 +5,6 @@
(async function() {
TestRunner.addResult(`Test that the command menu is properly filled.\n`);
self.runtime.loadModulePromise('quick_open').then(() => {
var categories = new Set();
var commands = new Map();
......@@ -14,6 +13,11 @@
commands.set(command.category() + ': ' + command.title(), command);
});
// Manually remove "Grid" because CSS Grid is still experimental but enabled by default
// see: https://crrev.com/c/2416525
// TODO: remove this and update test expectations once CSS Grid is non-experimental
categories.delete('Grid');
TestRunner.addResult('Categories active:');
Array.from(categories).sort().forEach(category => TestRunner.addResult('Has category: ' + category));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment