Commit 1b48bd74 authored by sandromaggi's avatar sandromaggi Committed by Commit Bot

[Autofill Assistant] Remove navigation feature

The condition has shown to be stable enough that the bailout can be
removed.

Bug: b/159309621
Change-Id: I4d66174ac0fd2c117d31aa81303b2d2ee1e7cf84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414179Reviewed-by: default avatarMathias Carlen <mcarlen@chromium.org>
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Cr-Commit-Position: refs/heads/master@{#808805}
parent a785a7c8
...@@ -1843,17 +1843,14 @@ void Controller::DidStartNavigation( ...@@ -1843,17 +1843,14 @@ void Controller::DidStartNavigation(
return; return;
} }
if (base::FeatureList::IsEnabled( // When in RUNNING state, all renderer initiated navigation is allowed,
features::kAutofillAssistantBreakOnRunningNavigation)) { // user initiated navigation will cause an error.
// When in RUNNING state, all renderer initiated navigation is allowed, if (state_ == AutofillAssistantState::RUNNING &&
// user initiated navigation will cause an error. !navigation_handle->WasServerRedirect() &&
if (state_ == AutofillAssistantState::RUNNING && !navigation_handle->IsRendererInitiated()) {
!navigation_handle->WasServerRedirect() && OnScriptError(l10n_util::GetStringUTF8(IDS_AUTOFILL_ASSISTANT_GIVE_UP),
!navigation_handle->IsRendererInitiated()) { Metrics::DropOutReason::NAVIGATION_WHILE_RUNNING);
OnScriptError(l10n_util::GetStringUTF8(IDS_AUTOFILL_ASSISTANT_GIVE_UP), return;
Metrics::DropOutReason::NAVIGATION_WHILE_RUNNING);
return;
}
} }
// Note that BROWSE state end conditions are in DidFinishNavigation, in order // Note that BROWSE state end conditions are in DidFinishNavigation, in order
......
...@@ -12,14 +12,6 @@ namespace features { ...@@ -12,14 +12,6 @@ namespace features {
const base::Feature kAutofillAssistant{"AutofillAssistant", const base::Feature kAutofillAssistant{"AutofillAssistant",
base::FEATURE_ENABLED_BY_DEFAULT}; base::FEATURE_ENABLED_BY_DEFAULT};
// Guard for the end condition when a non-renderer-initiated navigation occurs
// while the AutofillAssistant is in RUNNING state.
// TODO(b/159309621): Remove this if the end condition shows no unwanted side
// effects.
const base::Feature kAutofillAssistantBreakOnRunningNavigation{
"AutofillAssistantBreakOnRunningNavigation",
base::FEATURE_ENABLED_BY_DEFAULT};
// Controls whether to enable Assistant Autofill in a normal Chrome tab. // Controls whether to enable Assistant Autofill in a normal Chrome tab.
const base::Feature kAutofillAssistantChromeEntry{ const base::Feature kAutofillAssistantChromeEntry{
"AutofillAssistantChromeEntry", base::FEATURE_ENABLED_BY_DEFAULT}; "AutofillAssistantChromeEntry", base::FEATURE_ENABLED_BY_DEFAULT};
......
...@@ -14,7 +14,6 @@ namespace features { ...@@ -14,7 +14,6 @@ namespace features {
// All features in alphabetical order. // All features in alphabetical order.
extern const base::Feature kAutofillAssistant; extern const base::Feature kAutofillAssistant;
extern const base::Feature kAutofillAssistantBreakOnRunningNavigation;
extern const base::Feature kAutofillAssistantChromeEntry; extern const base::Feature kAutofillAssistantChromeEntry;
extern const base::Feature kAutofillAssistantDirectActions; extern const base::Feature kAutofillAssistantDirectActions;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment