Skip to content

GitLab

T
tangled
Commit 1b59e494 authored by ericwilligers's avatar ericwilligers Committed by Commit bot
Browse files
Options

Improve tracing for sibling style invalidation 

The trace event is associated with the element that was updated,
instead of incorrectly being associated with the element's parent.

BUG=378135

Review URL: https://codereview.chromium.org/1473093002

Cr-Commit-Position: refs/heads/master@{#361292}
parent e8de0bc0
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 8 deletions
third_party/WebKit/Source/core/css/RuleFeature.cpp
View file @ 1b59e494
......@@ -608,8 +608,7 @@ void RuleFeatureSet::collectInvalidationSetsForClass(InvalidationLists& invalida
invalidationLists.descendants.append(invalidationData->descendants());
}
if (invalidationData->siblings()) {
if (element.parentElement())
TRACE_SCHEDULE_STYLE_INVALIDATION(*element.parentElement(), *invalidationData->siblings(), classChange, className);
TRACE_SCHEDULE_STYLE_INVALIDATION(element, *invalidationData->siblings(), classChange, className);
invalidationLists.siblings.append(invalidationData->siblings());
}
}
......@@ -623,8 +622,7 @@ void RuleFeatureSet::collectInvalidationSetsForId(InvalidationLists& invalidatio
invalidationLists.descendants.append(invalidationData->descendants());
}
if (invalidationData->siblings()) {
if (element.parentElement())
TRACE_SCHEDULE_STYLE_INVALIDATION(*element.parentElement(), *invalidationData->siblings(), idChange, id);
TRACE_SCHEDULE_STYLE_INVALIDATION(element, *invalidationData->siblings(), idChange, id);
invalidationLists.siblings.append(invalidationData->siblings());
}
}
......@@ -638,8 +636,7 @@ void RuleFeatureSet::collectInvalidationSetsForAttribute(InvalidationLists& inva
invalidationLists.descendants.append(invalidationData->descendants());
}
if (invalidationData->siblings()) {
if (element.parentElement())
TRACE_SCHEDULE_STYLE_INVALIDATION(*element.parentElement(), *invalidationData->siblings(), attributeChange, attributeName);
TRACE_SCHEDULE_STYLE_INVALIDATION(element, *invalidationData->siblings(), attributeChange, attributeName);
invalidationLists.siblings.append(invalidationData->siblings());
}
}
......@@ -653,8 +650,7 @@ void RuleFeatureSet::collectInvalidationSetsForPseudoClass(InvalidationLists& in
invalidationLists.descendants.append(invalidationData->descendants());
}
if (invalidationData->siblings()) {
if (element.parentElement())
TRACE_SCHEDULE_STYLE_INVALIDATION(*element.parentElement(), *invalidationData->siblings(), pseudoChange, pseudo);
TRACE_SCHEDULE_STYLE_INVALIDATION(element, *invalidationData->siblings(), pseudoChange, pseudo);
invalidationLists.siblings.append(invalidationData->siblings());
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment