Commit 1b5a9941 authored by George Burgess IV's avatar George Burgess IV Committed by Commit Bot

app_service: fix a use-after-move in a test

Was this intended to be a use-after-move? Or not? Only one way to find
out! (This was flagged by clang-tidy as potentially buggy code, since
uses of things after std::move is often a programmer error)

Bug: None
Change-Id: I274839476d5787820a03aa5e358fd35617a14786
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202693Reviewed-by: default avatarDominick Ng <dominickn@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798562}
parent 7a5f5cae
...@@ -714,17 +714,15 @@ class AppUpdateTest : public testing::Test { ...@@ -714,17 +714,15 @@ class AppUpdateTest : public testing::Test {
auto scheme_condition = auto scheme_condition =
apps_util::MakeCondition(apps::mojom::ConditionType::kScheme, apps_util::MakeCondition(apps::mojom::ConditionType::kScheme,
std::move(scheme_condition_values)); std::move(scheme_condition_values));
intent_filter->conditions.push_back(std::move(scheme_condition));
std::vector<apps::mojom::ConditionValuePtr> host_condition_values; std::vector<apps::mojom::ConditionValuePtr> host_condition_values;
host_condition_values.push_back(apps_util::MakeConditionValue( host_condition_values.push_back(apps_util::MakeConditionValue(
"www.google.com", apps::mojom::PatternMatchType::kNone)); "www.google.com", apps::mojom::PatternMatchType::kNone));
auto host_condition = apps_util::MakeCondition( auto host_condition = apps_util::MakeCondition(
apps::mojom::ConditionType::kHost, std::move(host_condition_values)); apps::mojom::ConditionType::kHost, std::move(host_condition_values));
intent_filter->conditions.push_back(std::move(host_condition));
intent_filter->conditions.push_back(scheme_condition.Clone()); intent_filter->conditions.push_back(std::move(scheme_condition));
intent_filter->conditions.push_back(host_condition.Clone()); intent_filter->conditions.push_back(std::move(host_condition));
state->intent_filters.push_back(intent_filter.Clone()); state->intent_filters.push_back(intent_filter.Clone());
expect_intent_filters_.push_back(intent_filter.Clone()); expect_intent_filters_.push_back(intent_filter.Clone());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment