Commit 1b68bf24 authored by Dominic Battre's avatar Dominic Battre Committed by Commit Bot

Proper disabling LocalNTPInterceptionWebRequestAPITest test

Disable LocalNTPInterceptionWebRequestAPITest.OneGoogleBarRequestsHidden when
run in servicified network stack but not otherwise. Flakes are caused due to a
bug in the servicified network stack, the test seems to work well on other
platforms.

Bug: 853118
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I02bf111449dd88c24c788d630e8e53f364e03265
Reviewed-on: https://chromium-review.googlesource.com/1123822Reviewed-by: default avatarDominic Battré <battre@chromium.org>
Reviewed-by: default avatarKen Rockot <rockot@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572278}
parent 6df2efa5
...@@ -1605,14 +1605,8 @@ class LocalNTPInterceptionWebRequestAPITest ...@@ -1605,14 +1605,8 @@ class LocalNTPInterceptionWebRequestAPITest
DISALLOW_COPY_AND_ASSIGN(LocalNTPInterceptionWebRequestAPITest); DISALLOW_COPY_AND_ASSIGN(LocalNTPInterceptionWebRequestAPITest);
}; };
// Flaky on Win7x64 and Linux. See https://crbug.com/853118.
#if defined(OS_WIN) || defined(OS_LINUX)
#define MAYBE_OneGoogleBarRequestsHidden DISABLED_OneGoogleBarRequestsHidden
#else
#define MAYBE_OneGoogleBarRequestsHidden OneGoogleBarRequestsHidden
#endif
IN_PROC_BROWSER_TEST_F(LocalNTPInterceptionWebRequestAPITest, IN_PROC_BROWSER_TEST_F(LocalNTPInterceptionWebRequestAPITest,
MAYBE_OneGoogleBarRequestsHidden) { OneGoogleBarRequestsHidden) {
// Loads an extension which tries to intercept requests to the OneGoogleBar. // Loads an extension which tries to intercept requests to the OneGoogleBar.
ExtensionTestMessageListener listener("ready", true /*will_reply*/); ExtensionTestMessageListener listener("ready", true /*will_reply*/);
const Extension* extension = const Extension* extension =
......
...@@ -265,6 +265,8 @@ ...@@ -265,6 +265,8 @@
-ExtensionWebRequestApiTest.WebRequestTestOSDD -ExtensionWebRequestApiTest.WebRequestTestOSDD
# Note WebRequestUnloadImmediately is disabled on Linux # Note WebRequestUnloadImmediately is disabled on Linux
-ExtensionWebRequestApiTest.WebRequestUnloadImmediately -ExtensionWebRequestApiTest.WebRequestUnloadImmediately
# http://crbug.com/853118 Flaky with serivicified network stack.
-LocalNTPInterceptionWebRequestAPITest.OneGoogleBarRequestsHidden
# WebRequest implementation needs to handle extension # WebRequest implementation needs to handle extension
# installation/uninstallation events. # installation/uninstallation events.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment