Commit 1b6d8e74 authored by cjhopman's avatar cjhopman Committed by Commit bot

Add DomDistiller.PageDistilledType and update DD.PageDistillableType

This adds a new distallable type (mobile-friendly distillable) and adds
a histogram for tracking what types of pages are actually distilled.

BUG=444160

Review URL: https://codereview.chromium.org/900963003

Cr-Commit-Position: refs/heads/master@{#314956}
parent 11fff3f2
...@@ -2557,7 +2557,7 @@ should be able to be added at any place in this file. ...@@ -2557,7 +2557,7 @@ should be able to be added at any place in this file.
<action name="DomDistiller_DistilledPageOpened"> <action name="DomDistiller_DistilledPageOpened">
<owner>smaslo@chromium.org</owner> <owner>smaslo@chromium.org</owner>
<owner>yfriedman@chromium.org</owner> <owner>yfriedman@chromium.org</owner>
<description>User opens a distilled page.</description> <description>User opens reader mode on a page.</description>
</action> </action>
<action name="DomDistiller_DistilledPagePrefsOpened"> <action name="DomDistiller_DistilledPagePrefsOpened">
......
...@@ -5461,11 +5461,19 @@ Therefore, the affected-histogram name has to have at least one dot in it. ...@@ -5461,11 +5461,19 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary> </summary>
</histogram> </histogram>
<histogram name="DomDistiller.PageDistillable" enum="BooleanDistillable"> <histogram name="DomDistiller.PageDistillable" enum="DistillableType">
<owner>yfriedman@chromium.org</owner> <owner>cjhopman@chromium.org</owner>
<summary>
Records the &quot;Distillable Type&quot; (not distillable, mobile-friendly
distillable, non-mobile-friendly distillable, etc) for each analyzed page.
</summary>
</histogram>
<histogram name="DomDistiller.PageDistilledType" enum="DistillableType">
<owner>cjhopman@chromium.org</owner>
<summary> <summary>
Records the number of times a page was loaded for which using DomDistiller Records the &quot;Distillable Type&quot; (not distillable, mobile-friendly
is possible. distillable, non-mobile-friendly distillable, etc) for each distilled page.
</summary> </summary>
</histogram> </histogram>
...@@ -43568,11 +43576,6 @@ Therefore, the affected-histogram name has to have at least one dot in it. ...@@ -43568,11 +43576,6 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<int value="1" label="Did fall back"/> <int value="1" label="Did fall back"/>
</enum> </enum>
<enum name="BooleanDistillable" type="int">
<int value="0" label="Not distillable"/>
<int value="1" label="Distillable"/>
</enum>
<enum name="BooleanDuplicate" type="int"> <enum name="BooleanDuplicate" type="int">
<int value="0" label="Not Duplicate"/> <int value="0" label="Not Duplicate"/>
<int value="1" label="Duplicate"/> <int value="1" label="Duplicate"/>
...@@ -44911,6 +44914,12 @@ Therefore, the affected-histogram name has to have at least one dot in it. ...@@ -44911,6 +44914,12 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<int value="3" label="Primary accounts present but different"/> <int value="3" label="Primary accounts present but different"/>
</enum> </enum>
<enum name="DistillableType" type="int">
<int value="0" label="Not distillable"/>
<int value="1" label="Non-mobile-friendly Distillable"/>
<int value="2" label="Mobile-friendly distillable"/>
</enum>
<enum name="DllHash" type="int"> <enum name="DllHash" type="int">
<!-- Generated by chrome_elf/dll_hash/dll_hash_main.cc --> <!-- Generated by chrome_elf/dll_hash/dll_hash_main.cc -->
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment