Skip to content

GitLab

T
tangled
Commit 1b6f77d3 authored by rajendrant's avatar rajendrant Committed by Commit Bot
Browse files
Options

Add css background image compression test 

Adds a browser test so that coverage ukm is recorded in both the modes
of enabling and disabling the actual image redirection.

Bug: 1047330
Change-Id: I97cfaa27f3089fc0d909c1357a3a3fa6b5c8405a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111784Reviewed-by: default avatarMichael Crouse <mcrouse@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752061}
parent 8870c632
Hide whitespace changes
Inline Side-by-side
Showing with 77 additions and 0 deletions
chrome/browser/data_saver/subresource_redirect_browsertest.cc
View file @ 1b6f77d3
...@@ -1030,3 +1030,66 @@ IN_PROC_BROWSER_TEST_F( ...@@ -1030,3 +1030,66 @@ IN_PROC_BROWSER_TEST_F(
VerifyIneligibleMissingInImageHintsUkm(0); VerifyIneligibleMissingInImageHintsUkm(0);
VerifyIneligibleOtherImageUkm(0); VerifyIneligibleOtherImageUkm(0);
} }
// Tests CSS background images are redirected.
IN_PROC_BROWSER_TEST_F(
SubresourceRedirectBrowserTest,
DISABLE_ON_WIN_MAC_CHROMEOS(TestCSSBackgroundImageRedirect)) {
EnableDataSaver(true);
CreateUkmRecorder();
SetUpPublicImageURLPaths("/load_image/css_background_image.html",
{"/load_image/image.png"});
ui_test_utils::NavigateToURLWithDisposition(
browser(), HttpsURLWithPath("/load_image/css_background_image.html"),
WindowOpenDisposition::NEW_FOREGROUND_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_LOAD_STOP);
RetryForHistogramUntilCountReached(
histogram_tester(), "SubresourceRedirect.CompressionAttempt.ResponseCode",
2);
base::RunLoop().RunUntilIdle();
histogram_tester()->ExpectBucketCount(
"SubresourceRedirect.CompressionAttempt.ResponseCode", net::HTTP_OK, 1);
histogram_tester()->ExpectBucketCount(
"SubresourceRedirect.CompressionAttempt.ResponseCode",
net::HTTP_TEMPORARY_REDIRECT, 1);
EXPECT_EQ(request_url().port(), compression_url().port());
VerifyCompressibleImageUkm(1);
VerifyIneligibleImageHintsUnavailableUkm(0);
VerifyIneligibleMissingInImageHintsUkm(0);
VerifyIneligibleOtherImageUkm(0);
}
// Tests CSS background image coverage metrics is recorded but not redirected,
// when redirect is disabled.
IN_PROC_BROWSER_TEST_F(
RedirectDisabledSubresourceRedirectBrowserTest,
DISABLE_ON_WIN_MAC_CHROMEOS(TestCSSBackgroundImageRedirect)) {
EnableDataSaver(true);
CreateUkmRecorder();
SetUpPublicImageURLPaths("/load_image/css_background_image.html",
{"/load_image/image.png"});
ui_test_utils::NavigateToURLWithDisposition(
browser(), HttpsURLWithPath("/load_image/css_background_image.html"),
WindowOpenDisposition::NEW_FOREGROUND_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_LOAD_STOP);
content::FetchHistogramsFromChildProcesses();
SubprocessMetricsProvider::MergeHistogramDeltasForTesting();
base::RunLoop().RunUntilIdle();
histogram_tester()->ExpectTotalCount(
"SubresourceRedirect.CompressionAttempt.ResponseCode", 0);
histogram_tester()->ExpectTotalCount(
"SubresourceRedirect.CompressionAttempt.ServerResponded", 0);
histogram_tester()->ExpectTotalCount(
"SubresourceRedirect.DidCompress.CompressionPercent", 0);
VerifyCompressibleImageUkm(1);
VerifyIneligibleImageHintsUnavailableUkm(0);
VerifyIneligibleMissingInImageHintsUkm(0);
VerifyIneligibleOtherImageUkm(0);
}
chrome/test/data/load_image/css_background_image.html 0 → 100644
View file @ 1b6f77d3
<!DOCTYPE html>
<html>
<style>
div.css_bg_image {
height: 800px;
background-color: #cccccc;
background-image: url("image.png");
}
</style>
<body>
<div class="css_bg_image"></div>
</body>
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment