Commit 1b7a4da6 authored by Michael Hansen's avatar Michael Hansen Committed by Commit Bot

[Nearby] Reduce onboarding dialog height.

This reduces the height of the onboarding dialog, and updates spacing
between other elements to fit the new height as well as to come
inline with the spec.

Screenshots:
  https://screenshot.googleplex.com/4KC2SMGEsQDDcZZ.png
  https://screenshot.googleplex.com/8wWbvuyZS5iS5YJ.png
  https://screenshot.googleplex.com/8v8wrjAfj2cMH5M.png

Spec:
  https://carbon.googleplex.com/cros-ux/pages/nearby-share/onboarding-flow

Bug: b:168841167
Change-Id: I311ca41b8c9269ba1c66ea1f86147894329e09d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530284
Commit-Queue: Michael Hansen <hansenmichael@google.com>
Reviewed-by: default avatarJames Vecore <vecore@google.com>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826902}
parent 2923377e
...@@ -65,7 +65,7 @@ constexpr int kCornerRadius = 12; ...@@ -65,7 +65,7 @@ constexpr int kCornerRadius = 12;
gfx::Size ComputeSize() { gfx::Size ComputeSize() {
// TODO(vecore): compute expected size based on screen size // TODO(vecore): compute expected size based on screen size
return {500, 500}; return {/*width=*/512, /*height=*/420};
} }
} // namespace } // namespace
......
...@@ -19,7 +19,7 @@ ...@@ -19,7 +19,7 @@
<style include="cr-icons cr-shared-style"> <style include="cr-icons cr-shared-style">
:host { :host {
--card-border-color: var(--google-grey-300); --card-border-color: var(--google-grey-300);
--cr-card-radio-button-padding: 8px 16px 8px 16px; --cr-card-radio-button-padding: 4px 12px 4px 12px;
--iron-icon-height: var(--cr-icon-size); --iron-icon-height: var(--cr-icon-size);
--iron-icon-width: var(--cr-icon-size); --iron-icon-width: var(--cr-icon-size);
} }
...@@ -31,18 +31,21 @@ ...@@ -31,18 +31,21 @@
#main { #main {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
line-height: 20px;
} }
#visibilityRadioGroup { #visibilityRadioGroup {
display: flex; display: flex;
justify-content: center; justify-content: center;
margin-block-end: 8px; margin-block-end: 16px;
} }
cr-card-radio-button { cr-card-radio-button {
border: 1px solid var(--card-border-color); border: 1px solid var(--card-border-color);
box-shadow: none; box-shadow: none;
flex: 1; flex: 1;
margin-block-end: 0;
margin-block-start: 0;
margin-inline-end: 5px; margin-inline-end: 5px;
margin-inline-start: 5px; margin-inline-start: 5px;
padding: 0; padding: 0;
...@@ -140,14 +143,12 @@ ...@@ -140,14 +143,12 @@
width: 100%; width: 100%;
} }
.viz-description-section div { .viz-description-section {
margin-block-end: 8px; margin-block-end: 8px;
} }
.explanation-section { .explanation-section {
display: flex; display: flex;
margin-block-end: 8px;
margin-block-start: 8px;
} }
.padded-icon { .padded-icon {
...@@ -160,7 +161,6 @@ ...@@ -160,7 +161,6 @@
#contactList { #contactList {
border-bottom: var(--cr-separator-line); border-bottom: var(--cr-separator-line);
border-top: var(--cr-separator-line); border-top: var(--cr-separator-line);
padding-block-start: 16px;
} }
#contactsHeading { #contactsHeading {
...@@ -168,9 +168,7 @@ ...@@ -168,9 +168,7 @@
} }
.contacts-section { .contacts-section {
height: 100px; height: 72px;
margin-block-end: 8px;
margin-block-start: 8px;
} }
.contact-item { .contact-item {
......
...@@ -19,7 +19,7 @@ ...@@ -19,7 +19,7 @@
#header { #header {
margin-inline-end: var(--nearby-page-space-inline); margin-inline-end: var(--nearby-page-space-inline);
margin-inline-start: var(--nearby-page-space-inline); margin-inline-start: var(--nearby-page-space-inline);
padding-block-end: var(--nearby-page-space-block); padding-block-end: 16px;
padding-block-start: var(--nearby-page-space-block); padding-block-start: var(--nearby-page-space-block);
} }
......
...@@ -18,11 +18,12 @@ ...@@ -18,11 +18,12 @@
<style> <style>
div.title { div.title {
font-weight: 500; font-weight: 500;
padding-bottom: 0; padding-block-end: 0;
padding-block-start: 24px;
} }
div.header { div.header {
padding-bottom: 20px; padding-block-end: 16px;
padding-inline-start: 20px; padding-inline-start: 20px;
} }
</style> </style>
......
...@@ -16,7 +16,7 @@ ...@@ -16,7 +16,7 @@
<template> <template>
<style> <style>
cr-dialog::part(dialog) { cr-dialog::part(dialog) {
height: 600px; height: 420px;
width: 512px; width: 512px;
} }
</style> </style>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment