DevTools: move group by product out of experiment

Review-Url: https://codereview.chromium.org/2874233003
Cr-Commit-Position: refs/heads/master@{#472262}

third_party/WebKit/Source/devtools/front_end/main/Main.js

@@ -109,7 +109,7 @@ Main.Main = class {
     Runtime.experiments.register('terminalInDrawer', 'Terminal in drawer', true);
 
     // Timeline
-    Runtime.experiments.register('timelineColorByProduct', 'Timeline: group and color by product', true);
+    Runtime.experiments.register('timelineColorByProduct', 'Timeline: color by product', true);
     Runtime.experiments.register('timelineEventInitiators', 'Timeline: event initiators');
     Runtime.experiments.register('timelineFlowEvents', 'Timeline: flow events', true);
     Runtime.experiments.register('timelineInvalidationTracking', 'Timeline: invalidation tracking', true);

third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

@@ -238,8 +238,6 @@ Timeline.TimelineTreeView = class extends UI.VBox {
    */
   refreshTree() {
     this._linkifier.reset();
-    if (this._searchableView)
-      this._searchableView.cancelSearch();
     this._dataGrid.rootNode().removeChildren();
     if (!this._model) {
       this._updateDetailsForSelection();
@@ -261,6 +259,8 @@ Timeline.TimelineTreeView = class extends UI.VBox {
     }
     this._sortingChanged();
     this._updateDetailsForSelection();
+    if (this._searchableView)
+      this._searchableView.refreshSearch();
   }
 
   /**
@@ -636,8 +636,6 @@ Timeline.AggregatedTimelineTreeView = class extends Timeline.TimelineTreeView {
     this._stackView = new Timeline.TimelineStackView(this);
     this._stackView.addEventListener(
         Timeline.TimelineStackView.Events.SelectionChanged, this._onStackViewSelectionChanged, this);
-    if (!Runtime.experiments.isEnabled('timelineColorByProduct'))
-      return;
     /** @type {!Map<string, string>} */
     this._productByURLCache = new Map();
     ProductRegistry.instance().then(registry => {
@@ -752,8 +750,6 @@ Timeline.AggregatedTimelineTreeView = class extends Timeline.TimelineTreeView {
       {label: Common.UIString('Group by Subdomain'), value: groupBy.Subdomain},
       {label: Common.UIString('Group by URL'), value: groupBy.URL},
     ];
-    if (!Runtime.experiments.isEnabled('timelineColorByProduct'))
-      options = options.filter(option => option.value !== groupBy.Product);
     toolbar.appendToolbarItem(new UI.ToolbarSettingComboBox(options, this._groupBySetting));
     toolbar.appendSpacer();
     toolbar.appendToolbarItem(this._splitWidget.createShowHideSidebarButton(Common.UIString('heaviest stack')));
@@ -863,7 +859,7 @@ Timeline.AggregatedTimelineTreeView = class extends Timeline.TimelineTreeView {
    */
   _productByEvent(event) {
     var url = TimelineModel.TimelineProfileTree.eventURL(event);
-    if (!url || !this._productByURLCache)
+    if (!url)
       return '';
     if (this._productByURLCache.has(url))
       return this._productByURLCache.get(url);