Commit 1baaf879 authored by Chris Nardi's avatar Chris Nardi Committed by Commit Bot

Update css_parser_proto_fuzzer

Due to modifications to the string lists in css_proto_converter.cc,
the proto definition no longer matched up with the proto converter.
Update both lists to match, including some additional properties/values
not previously included. Also remove the restriction on building the
fuzzer for Windows, as it appears to build now.

Bug: 990327
Change-Id: I0c2b22a0db2aae3c53bb95eb5f539b151be3dddf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742727Reviewed-by: default avatarJonathan Metzman <metzman@chromium.org>
Reviewed-by: default avatarRune Lillesveen <futhark@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688564}
parent 5a26bb98
...@@ -1714,30 +1714,25 @@ fuzzer_test("content_security_policy_fuzzer") { ...@@ -1714,30 +1714,25 @@ fuzzer_test("content_security_policy_fuzzer") {
seed_corpus = "//testing/libfuzzer/fuzzers/content_security_policy_corpus" seed_corpus = "//testing/libfuzzer/fuzzers/content_security_policy_corpus"
} }
# Since libFuzzer isn't working on Windows, and the proto_library cannot build fuzzer_test("css_parser_proto_fuzzer") {
# on Windows because of a build error, prevent it from being built on Windows. sources = [
# TODO(metzman): Figure out how to get this building on Windows. "css/parser/css_parser_proto_fuzzer.cc",
if (!is_win) { "css/parser/css_proto_converter.cc",
fuzzer_test("css_parser_proto_fuzzer") { "css/parser/css_proto_converter.h",
sources = [ ]
"css/parser/css_parser_proto_fuzzer.cc", deps = [
"css/parser/css_proto_converter.cc", ":core",
"css/parser/css_proto_converter.h", ":css_proto",
] "//third_party/blink/renderer/platform:blink_fuzzer_test_support",
deps = [ "//third_party/libprotobuf-mutator",
":core", ]
":css_proto", dict = "//third_party/blink/renderer/core/css/css.dict"
"//third_party/blink/renderer/platform:blink_fuzzer_test_support", }
"//third_party/libprotobuf-mutator",
]
dict = "//third_party/blink/renderer/core/css/css.dict"
}
proto_library("css_proto") { proto_library("css_proto") {
sources = [ sources = [
"css/parser/css.proto", "css/parser/css.proto",
] ]
}
} }
# Fuzzers for blink::FeaturePolicy. # Fuzzers for blink::FeaturePolicy.
......
...@@ -111,8 +111,6 @@ const std::string Converter::kPseudoLookupTable[] = { ...@@ -111,8 +111,6 @@ const std::string Converter::kPseudoLookupTable[] = {
"visited", "visited",
"window-inactive", "window-inactive",
"-webkit-any", "-webkit-any",
"cue",
"host",
"host-context", "host-context",
"lang", "lang",
"not", "not",
...@@ -922,6 +920,40 @@ const std::string Converter::kValueLookupTable[] = { ...@@ -922,6 +920,40 @@ const std::string Converter::kValueLookupTable[] = {
"inset", "inset",
"mediumaquamarine", "mediumaquamarine",
"scroll", "scroll",
"layout",
"break-spaces",
"pan-left",
"proximity",
"inline-start",
"pan-x",
"grab",
"grabbing",
"inline-end",
"pan-right",
"jump-end",
"manipulation",
"pinch-zoom",
"xxx-large",
"pan-down",
"anywhere",
"jump-none",
"drag",
"avoid-page",
"mandatory",
"paint",
"jump-both",
"size",
"style",
"pan-y",
"recto",
"markers",
"verso",
"page",
"pan-up",
"avoid-column",
"smooth",
"jump-start",
"no-drag",
"INVALID_VALUE", "INVALID_VALUE",
}; };
...@@ -1482,6 +1514,10 @@ const std::string Converter::kPropertyLookupTable[] = { ...@@ -1482,6 +1514,10 @@ const std::string Converter::kPropertyLookupTable[] = {
"overflow-block", "overflow-block",
"overflow-inline", "overflow-inline",
"forced-color-adjust", "forced-color-adjust",
"overscroll-behavior-inline",
"overscroll-behavior-block",
"overscroll-behavior-x",
"overscroll-behavior-y",
"INVALID_PROPERTY", "INVALID_PROPERTY",
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment