Commit 1bb578db authored by rsesek@chromium.org's avatar rsesek@chromium.org

Do not pass -dead_strip to ld for the Mac helper and main apps.

On certain SDK versions and OSes with the 10.6 deployment target, the linker, if
invoked with -dead_strip, incorrectly removes _NXArgc and _NXArgv. Since the
apps are just shims into the Framework, there's little to strip anyways.

BUG=139902
TEST=Build on 10.7+ with GYP variable mac_strip_release=1.

Review URL: https://chromiumcodereview.appspot.com/10830126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149531 0039d316-1c4b-4281-b951-d872f2087c98
parent 2a6fd37f
......@@ -420,6 +420,16 @@
'CHROMIUM_STRIP_SAVE_FILE': 'app/app.saves',
'INFOPLIST_FILE': 'app/helper-Info.plist',
},
# Turn off -dead_strip in Release mode for the helper app. There's
# little here to strip, and doing so preserves symbols from
# crt1.10.6.o, which get removed incorrectly. http://crbug.com/139902
'configurations': {
'Release': {
'xcode_settings': {
'DEAD_CODE_STRIPPING': 'NO',
},
},
},
'postbuilds': [
{
# The helper doesn't have real localizations, it just has
......
......@@ -247,6 +247,16 @@
'CHROMIUM_CREATOR': '<(mac_creator)',
'CHROMIUM_SHORT_NAME': '<(branding)',
},
# Turn off -dead_strip in Release mode for the main app. There's
# little here to strip, and doing so preserves symbols from
# crt1.10.6.o, which get removed incorrectly. http://crbug.com/139902
'configurations': {
'Release': {
'xcode_settings': {
'DEAD_CODE_STRIPPING': 'NO',
},
},
},
'dependencies': [
'helper_app',
'infoplist_strings_tool',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment