Fix most GN clang errors.

Finally enabling Clang requires openssl and hunspell rolls. This should
fix everything else.

R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/402683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283894 0039d316-1c4b-4281-b951-d872f2087c98

breakpad/BUILD.gn

@@ -420,6 +420,8 @@ if (is_linux && current_toolchain == host_toolchain) {
       "src/common/string_conversion.h",
     ]
 
+    configs -= [ "//build/config/compiler:chromium_code" ]
+    configs += [ "//build/config/compiler:no_chromium_code" ]
     direct_dependent_configs = [ ":breakpad_client_config" ]
 
     # Android NDK toolchain doesn't support -mimplicit-it=always
@@ -551,7 +553,8 @@ if (is_linux && current_toolchain == host_toolchain) {
     ]
 
     # This file has an unused variable warning.
-    cflags = [ "-Wno-unused-variable" ]
+    configs -= [ "//build/config/compiler:chromium_code" ]
+    configs += [ "//build/config/compiler:no_chromium_code" ]
 
     deps = [ ":breakpad_client" ]
 

media/audio/pulse/audio_manager_pulse.cc

@@ -42,8 +42,10 @@ static const int kMaximumOutputBufferSize = 8192;
 // Default input buffer size.
 static const int kDefaultInputBufferSize = 1024;
 
+#if defined(DLOPEN_PULSEAUDIO)
 static const base::FilePath::CharType kPulseLib[] =
     FILE_PATH_LITERAL("libpulse.so.0");
+#endif
 
 // static
 AudioManager* AudioManagerPulse::Create(AudioLogFactory* audio_log_factory) {

third_party/opus/BUILD.gn

@@ -53,6 +53,8 @@ source_set("opus") {
     "src/silk",
   ]
 
+  configs -= [ "//build/config/compiler:chromium_code" ]
+  configs += [ "//build/config/compiler:no_chromium_code" ]
   direct_dependent_configs = [ ":opus_config" ]
 
   if (is_win) {
@@ -141,6 +143,9 @@ executable("opus_demo") {
     "src/src/opus_demo.c",
   ]
 
+  configs -= [ "//build/config/compiler:chromium_code" ]
+  configs += [ "//build/config/compiler:no_chromium_code" ]
+
   include_dirs = [
     "src/celt",
     "src/silk",