Commit 1bc6c6f4 authored by Abigail Klein's avatar Abigail Klein Committed by Chromium LUCI CQ

[Live Caption] Make the SODAInstaller destructor virtual and override it

in SODAInstallerImplChromeOS.

This fixes an overlooked nit whereby the SODAInstallerImpl was
overriding a non-virtual destructor in its parent class, and the
SODAInstallerImplChromeOS was not.

Bug: 1055150
Change-Id: If039f7e046201bcc776f493338c0bffcea365a04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572942Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/master@{#833782}
parent ce074ea4
......@@ -30,7 +30,7 @@ class SODAInstaller {
};
SODAInstaller();
~SODAInstaller();
virtual ~SODAInstaller();
SODAInstaller(const SODAInstaller&) = delete;
SODAInstaller& operator=(const SODAInstaller&) = delete;
......
......@@ -17,7 +17,7 @@ namespace speech {
class SODAInstallerImplChromeOS : public SODAInstaller {
public:
SODAInstallerImplChromeOS();
~SODAInstallerImplChromeOS();
~SODAInstallerImplChromeOS() override;
SODAInstallerImplChromeOS(const SODAInstallerImplChromeOS&) = delete;
SODAInstallerImplChromeOS& operator=(const SODAInstallerImplChromeOS&) =
delete;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment