Commit 1bd82009 authored by Nico Weber's avatar Nico Weber Committed by Commit Bot

mac/asan: Enable asan range checking for globals.

I was very confused by asan not catching an out-of-bounds read of
a global. Turns out we turn it off. Let's not do that.

Bug: 352073
Cq-Include-Trybots: luci.chromium.try:mac_chromium_asan_rel_ng
Change-Id: I299a40a125de6a5addc26fa9d2fbdf39b6f66169
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527366
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: default avatarHans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827214}
parent 086b4ed5
...@@ -283,12 +283,6 @@ config("asan_flags") { ...@@ -283,12 +283,6 @@ config("asan_flags") {
# https://crbug.com/708707 # https://crbug.com/708707
cflags += [ "-fno-sanitize-address-use-after-scope" ] cflags += [ "-fno-sanitize-address-use-after-scope" ]
} }
if (!asan_globals) {
cflags += [
"-mllvm",
"-asan-globals=0",
]
}
if (asan_use_blacklist) { if (asan_use_blacklist) {
if (is_win) { if (is_win) {
if (!defined(asan_win_blacklist_path)) { if (!defined(asan_win_blacklist_path)) {
......
...@@ -172,11 +172,6 @@ declare_args() { ...@@ -172,11 +172,6 @@ declare_args() {
# builds. # builds.
use_clang_profiling_inside_sandbox = use_clang_profiling_inside_sandbox =
use_clang_profiling && !use_fuzzing_engine use_clang_profiling && !use_fuzzing_engine
# Detect overflow/underflow for global objects.
#
# Mac: http://crbug.com/352073
asan_globals = !is_mac
} }
if (use_fuzzing_engine && sanitizer_coverage_flags == "") { if (use_fuzzing_engine && sanitizer_coverage_flags == "") {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment