Commit 1bdf4c59 authored by thestig@chromium.org's avatar thestig@chromium.org

Print Preview: Use the global PrintPreviewTabController in unit tests.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8549012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110756 0039d316-1c4b-4281-b951-d872f2087c98
parent 133966f3
...@@ -41,8 +41,8 @@ TEST_F(PrintPreviewTabControllerUnitTest, MAYBE_GetOrCreatePreviewTab) { ...@@ -41,8 +41,8 @@ TEST_F(PrintPreviewTabControllerUnitTest, MAYBE_GetOrCreatePreviewTab) {
TabContentsWrapper* initiator_tab = TabContentsWrapper* initiator_tab =
browser()->GetSelectedTabContentsWrapper(); browser()->GetSelectedTabContentsWrapper();
scoped_refptr<printing::PrintPreviewTabController> printing::PrintPreviewTabController* tab_controller =
tab_controller(new printing::PrintPreviewTabController()); printing::PrintPreviewTabController::GetInstance();
ASSERT_TRUE(tab_controller); ASSERT_TRUE(tab_controller);
// Get the preview tab for initiator tab. // Get the preview tab for initiator tab.
...@@ -93,8 +93,8 @@ TEST_F(PrintPreviewTabControllerUnitTest, MAYBE_MultiplePreviewTabs) { ...@@ -93,8 +93,8 @@ TEST_F(PrintPreviewTabControllerUnitTest, MAYBE_MultiplePreviewTabs) {
ASSERT_TRUE(tab_contents_2); ASSERT_TRUE(tab_contents_2);
EXPECT_EQ(2, browser()->tab_count()); EXPECT_EQ(2, browser()->tab_count());
scoped_refptr<printing::PrintPreviewTabController> printing::PrintPreviewTabController* tab_controller =
tab_controller(new printing::PrintPreviewTabController()); printing::PrintPreviewTabController::GetInstance();
ASSERT_TRUE(tab_controller); ASSERT_TRUE(tab_controller);
// Create preview tab for |tab_contents_1| // Create preview tab for |tab_contents_1|
...@@ -153,8 +153,8 @@ TEST_F(PrintPreviewTabControllerUnitTest, MAYBE_ClearInitiatorTabDetails) { ...@@ -153,8 +153,8 @@ TEST_F(PrintPreviewTabControllerUnitTest, MAYBE_ClearInitiatorTabDetails) {
TabContentsWrapper* initiator_tab = TabContentsWrapper* initiator_tab =
browser()->GetSelectedTabContentsWrapper(); browser()->GetSelectedTabContentsWrapper();
scoped_refptr<printing::PrintPreviewTabController> printing::PrintPreviewTabController* tab_controller =
tab_controller(new printing::PrintPreviewTabController()); printing::PrintPreviewTabController::GetInstance();
ASSERT_TRUE(tab_controller); ASSERT_TRUE(tab_controller);
// Get the preview tab for initiator tab. // Get the preview tab for initiator tab.
......
...@@ -59,9 +59,9 @@ class PrintPreviewHandlerTest : public BrowserWithTestWindowTest { ...@@ -59,9 +59,9 @@ class PrintPreviewHandlerTest : public BrowserWithTestWindowTest {
browser()->GetSelectedTabContentsWrapper(); browser()->GetSelectedTabContentsWrapper();
ASSERT_TRUE(initiator_tab); ASSERT_TRUE(initiator_tab);
scoped_refptr<printing::PrintPreviewTabController> printing::PrintPreviewTabController* controller =
controller(new printing::PrintPreviewTabController()); printing::PrintPreviewTabController::GetInstance();
ASSERT_TRUE(controller.get()); ASSERT_TRUE(controller);
preview_tab_ = controller->GetOrCreatePreviewTab(initiator_tab); preview_tab_ = controller->GetOrCreatePreviewTab(initiator_tab);
ASSERT_TRUE(preview_tab_); ASSERT_TRUE(preview_tab_);
......
...@@ -50,8 +50,8 @@ TEST_F(PrintPreviewUIUnitTest, MAYBE_PrintPreviewData) { ...@@ -50,8 +50,8 @@ TEST_F(PrintPreviewUIUnitTest, MAYBE_PrintPreviewData) {
ASSERT_TRUE(initiator_tab); ASSERT_TRUE(initiator_tab);
EXPECT_EQ(0U, GetConstrainedWindowCount(initiator_tab)); EXPECT_EQ(0U, GetConstrainedWindowCount(initiator_tab));
scoped_refptr<printing::PrintPreviewTabController> printing::PrintPreviewTabController* controller =
controller(new printing::PrintPreviewTabController()); printing::PrintPreviewTabController::GetInstance();
ASSERT_TRUE(controller); ASSERT_TRUE(controller);
TabContentsWrapper* preview_tab = TabContentsWrapper* preview_tab =
......
...@@ -11,6 +11,7 @@ ...@@ -11,6 +11,7 @@
#include "chrome/browser/prefs/pref_service.h" #include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/prerender/prerender_tracker.h" #include "chrome/browser/prerender/prerender_tracker.h"
#include "chrome/browser/printing/background_printing_manager.h" #include "chrome/browser/printing/background_printing_manager.h"
#include "chrome/browser/printing/print_preview_tab_controller.h"
#include "chrome/browser/profiles/profile_manager.h" #include "chrome/browser/profiles/profile_manager.h"
#include "content/browser/debugger/devtools_manager.h" #include "content/browser/debugger/devtools_manager.h"
#include "net/url_request/url_request_context_getter.h" #include "net/url_request/url_request_context_getter.h"
...@@ -197,7 +198,9 @@ printing::PrintJobManager* TestingBrowserProcess::print_job_manager() { ...@@ -197,7 +198,9 @@ printing::PrintJobManager* TestingBrowserProcess::print_job_manager() {
printing::PrintPreviewTabController* printing::PrintPreviewTabController*
TestingBrowserProcess::print_preview_tab_controller() { TestingBrowserProcess::print_preview_tab_controller() {
return NULL; if (!print_preview_tab_controller_.get())
print_preview_tab_controller_ = new printing::PrintPreviewTabController();
return print_preview_tab_controller_.get();
} }
printing::BackgroundPrintingManager* printing::BackgroundPrintingManager*
......
...@@ -121,7 +121,7 @@ class TestingBrowserProcess : public BrowserProcess { ...@@ -121,7 +121,7 @@ class TestingBrowserProcess : public BrowserProcess {
void SetGoogleURLTracker(GoogleURLTracker* google_url_tracker); void SetGoogleURLTracker(GoogleURLTracker* google_url_tracker);
void SetProfileManager(ProfileManager* profile_manager); void SetProfileManager(ProfileManager* profile_manager);
void SetIOThread(IOThread* io_thread); void SetIOThread(IOThread* io_thread);
void SetDevToolsManager(DevToolsManager*); void SetDevToolsManager(DevToolsManager* manager);
void SetBrowserPolicyConnector(policy::BrowserPolicyConnector* connector); void SetBrowserPolicyConnector(policy::BrowserPolicyConnector* connector);
private: private:
...@@ -137,6 +137,8 @@ class TestingBrowserProcess : public BrowserProcess { ...@@ -137,6 +137,8 @@ class TestingBrowserProcess : public BrowserProcess {
scoped_ptr<ProfileManager> profile_manager_; scoped_ptr<ProfileManager> profile_manager_;
scoped_ptr<NotificationUIManager> notification_ui_manager_; scoped_ptr<NotificationUIManager> notification_ui_manager_;
scoped_ptr<printing::BackgroundPrintingManager> background_printing_manager_; scoped_ptr<printing::BackgroundPrintingManager> background_printing_manager_;
scoped_refptr<printing::PrintPreviewTabController>
print_preview_tab_controller_;
scoped_ptr<prerender::PrerenderTracker> prerender_tracker_; scoped_ptr<prerender::PrerenderTracker> prerender_tracker_;
IOThread* io_thread_; IOThread* io_thread_;
scoped_ptr<DevToolsManager> devtools_manager_; scoped_ptr<DevToolsManager> devtools_manager_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment