cros: Split AppListSearchQueryLength by clamshell and tablet mode

Bug: 953525
Change-Id: I3541430056b9924d9d249f4c6329c249b74bb172
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574610
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653502}

ash/app_list/app_list_controller_impl.cc

@@ -841,6 +841,13 @@ void AppListControllerImpl::OpenSearchResult(
 
     UMA_HISTOGRAM_COUNTS_100(app_list::kSearchQueryLength,
                              last_raw_query_.size());
+    if (IsTabletMode()) {
+      UMA_HISTOGRAM_COUNTS_100(app_list::kSearchQueryLengthInTablet,
+                               last_raw_query_.size());
+    } else {
+      UMA_HISTOGRAM_COUNTS_100(app_list::kSearchQueryLengthInClamshell,
+                               last_raw_query_.size());
+    }
 
     if (result->distance_from_origin() >= 0) {
       UMA_HISTOGRAM_COUNTS_100(app_list::kSearchResultDistanceFromOrigin,

ash/app_list/app_list_metrics.h

@@ -89,6 +89,16 @@ constexpr char kSearchResultOpenDisplayTypeHistogram[] =
 // opened.
 constexpr char kSearchQueryLength[] = "Apps.AppListSearchQueryLength";
 
+// The UMA histogram that logs how long the search query was when a result was
+// opened in clamshell mode.
+constexpr char kSearchQueryLengthInClamshell[] =
+    "Apps.AppListSearchQueryLength.ClamshellMode";
+
+// The UMA histogram that logs how long the search query was when a result was
+// opened in tablet mode.
+constexpr char kSearchQueryLengthInTablet[] =
+    "Apps.AppListSearchQueryLength.TabletMode";
+
 // The UMA histogram that logs the Manhattan distance from the origin of the
 // search results to the selected result.
 constexpr char kSearchResultDistanceFromOrigin[] =

tools/metrics/histograms/histograms.xml

@@ -4128,6 +4128,8 @@ uploading your change for review.
 </histogram>
 
 <histogram name="Apps.AppListSearchQueryLength" units="characters">
+<!-- Name completed by histogram_suffixes name="TabletOrClamshellMode" -->
+
   <owner>calamity@chromium.org</owner>
   <summary>
     The length of the app list search query when a result is opened. This is
@@ -155739,6 +155741,7 @@ should be kept until we use this API.  -->
   <suffix name="ClamshellMode" label="Clamshell Mode Enabled"/>
   <suffix name="TabletMode" label="Tablet Mode Enabled"/>
   <affected-histogram name="Apps.AppListFolderNameLength"/>
+  <affected-histogram name="Apps.AppListSearchQueryLength"/>
   <affected-histogram name="Apps.AppListSearchResultOpenTypeV2"/>
   <affected-histogram
       name="Apps.PaginationTransition.DragScroll.PresentationTime"/>