Commit 1bf44743 authored by Devlin Cronin's avatar Devlin Cronin Committed by Commit Bot

[Extensions Bindings] Correctly use a StrictMock for the IPC Sender

We have a UseStrictIPCMessageSender() method in
NativeExtensionBindingsSystemUnittest, but it wasn't being checked
when we instantiated the IPCMessageSender. Correctly check it so that
tests that want strict mocking get it.

Bug: 653596

Change-Id: Ib18945a14e0a88788bcfe9e56c530ff0ae2b36ca
Reviewed-on: https://chromium-review.googlesource.com/786900Reviewed-by: default avatarJeremy Roman <jbroman@chromium.org>
Reviewed-by: default avatarIstiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519896}
parent d693f0c7
...@@ -41,10 +41,16 @@ NativeExtensionBindingsSystemUnittest::GetV8ExtensionConfiguration() { ...@@ -41,10 +41,16 @@ NativeExtensionBindingsSystemUnittest::GetV8ExtensionConfiguration() {
void NativeExtensionBindingsSystemUnittest::SetUp() { void NativeExtensionBindingsSystemUnittest::SetUp() {
render_thread_ = std::make_unique<content::MockRenderThread>(); render_thread_ = std::make_unique<content::MockRenderThread>();
script_context_set_ = std::make_unique<ScriptContextSet>(&extension_ids_); script_context_set_ = std::make_unique<ScriptContextSet>(&extension_ids_);
auto ipc_message_sender = std::make_unique<TestIPCMessageSender>(); std::unique_ptr<TestIPCMessageSender> message_sender;
ipc_message_sender_ = ipc_message_sender.get(); if (UseStrictIPCMessageSender()) {
message_sender =
std::make_unique<testing::StrictMock<TestIPCMessageSender>>();
} else {
message_sender = std::make_unique<TestIPCMessageSender>();
}
ipc_message_sender_ = message_sender.get();
bindings_system_ = std::make_unique<NativeExtensionBindingsSystem>( bindings_system_ = std::make_unique<NativeExtensionBindingsSystem>(
std::move(ipc_message_sender)); std::move(message_sender));
APIBindingTest::SetUp(); APIBindingTest::SetUp();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment