Stop using all_dependent_configs in //third_party/googletest.

The usage of all_dependent_configs is considered a GN anti-pattern and
it should be used only when the public_deps/deps/public_configs/configs
system is not enough.

There is no real reason to use all_dependent_configs in
//third_party/googletest and since its usage has increased in
crrev.com/c/2090420, this CL addresses the problems and removes its
usage.


Bug: 1059240
Change-Id: I4ff2bd0a19ad2ddd0b25866fcf738ab2d05a523b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091487
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747997}

base/test/BUILD.gn

@@ -159,12 +159,12 @@ static_library("test_support") {
     "//base",
     "//base:base_static",
     "//base:i18n",
+    "//testing/gmock",
+    "//testing/gtest",
   ]
 
   deps = [
     "//base/third_party/dynamic_annotations",
-    "//testing/gmock",
-    "//testing/gtest",
     "//third_party/icu:icuuc",
     "//third_party/libxml:libxml_utils",
     "//third_party/libxml:xml_reader",

components/exo/BUILD.gn

@@ -156,6 +156,8 @@ source_set("test_support") {
     "test/exo_test_suite_aura.h",
   ]
 
+  public_deps = [ "//testing/gtest" ]
+
   deps = [
     ":exo",
     "//base",
@@ -163,7 +165,6 @@ source_set("test_support") {
     "//components/viz/service",
     "//gpu",
     "//skia",
-    "//testing/gtest",
     "//ui/aura",
     "//ui/base/ime/init",
     "//ui/compositor",

ios/web/public/test/BUILD.gn

@@ -9,6 +9,7 @@ source_set("test") {
   public_deps = [
     ":util",
     "//ios/web/public/test/fakes",
+    "//testing/gtest",
   ]
 
   deps = [
@@ -21,7 +22,6 @@ source_set("test") {
     "//ios/web/navigation:wk_navigation_util",
     "//ios/web/public/deprecated",
     "//ios/web/test:test_support",
-    "//testing/gtest",
     "//ui/base",
   ]
 

ios/web/test/BUILD.gn

@@ -48,6 +48,10 @@ source_set("test_support") {
   configs += [ "//build/config/compiler:enable_arc" ]
   testonly = true
 
+  # This public_dep is a workaround because there is a circular dependency
+  # (this target should public_dep on //ios/web/public/test).
+  public_deps = [ "//testing/gtest" ]
+
   deps = [
     ":test_constants",
     "//base",
@@ -61,7 +65,6 @@ source_set("test_support") {
     "//ios/web/public/test/http_server",
     "//ios/web/test/fakes",
     "//net",
-    "//testing/gtest",
     "//third_party/ocmock",
     "//ui/base",
   ]

third_party/googletest/BUILD.gn

@@ -115,10 +115,9 @@ source_set("gtest") {
   # Some files include "src/gtest-internal-inl.h".
   include_dirs = [ "src/googletest" ]
 
-  # TODO(crbug.com/1059240): Remove usage of all_dependent_configs.
-  all_dependent_configs = [ ":gtest_config" ]
+  public_configs = [ ":gtest_config" ]
   if (!build_with_chromium && gtest_enable_absl_printers) {
-    all_dependent_configs += [ "//third_party/abseil-cpp:absl_include_config" ]
+    public_configs += [ "//third_party/abseil-cpp:absl_include_config" ]
   }
 
   configs -= [ "//build/config/compiler:chromium_code" ]

ui/views/BUILD.gn

@@ -956,7 +956,6 @@ jumbo_source_set("test_support") {
     "//ipc:test_support",
     "//mojo/core/embedder",
     "//skia",
-    "//testing/gtest",
     "//ui/base",
     "//ui/base:test_support",
     "//ui/base/clipboard:clipboard_test_support",
@@ -971,6 +970,7 @@ jumbo_source_set("test_support") {
     "//ui/gfx/geometry",
     "//ui/gl:test_support",
   ]
+  public_deps = [ "//testing/gtest" ]
 
   if (is_win) {
     sources += [