Skip to content

GitLab

T
tangled
Commit 1c12500a authored by Xiaocheng Hu's avatar Xiaocheng Hu Committed by Commit Bot
Browse files
Options

Convert fast/inline/dirtyLinesForInline.html with W3C testharness 

This patch converts the layout test with W3C testharness so that
it doesn't rely on text dump comparison.

This is also a preparation for using element.innerText as text
dump; otherwise, this test generates different innerText dumps on
different platforms (crrev.com/c/1318149), which is undesired.

Bug: 887148
Change-Id: Ic279b9362ff054eb13f847e111baef37d0ef79e3
Reviewed-on: https://chromium-review.googlesource.com/c/1323890Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606313}
parent eec86ff6
Hide whitespace changes
Inline Side-by-side
Showing with 26 additions and 33 deletions
third_party/WebKit/LayoutTests/fast/inline/dirtyLinesForInline-expected.txt deleted 100644 → 0
View file @ eec86ff6
To reproduce this bug outside of DumpRenderTree, mouse over the links below several times. The bug is fixed if we don't crash.
this is the home pagehome
this is the about us pageabout us
third_party/WebKit/LayoutTests/fast/inline/dirtyLinesForInline.html
View file @ 1c12500a
<html> <html>
<head> <head>
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<style> <style>
.main_links:hover{ font-size: 11px; } .main_links:hover{ font-size: 11px; }
...@@ -27,34 +29,30 @@ The bug is fixed if we don't crash. </p> ...@@ -27,34 +29,30 @@ The bug is fixed if we don't crash. </p>
</div> </div>
<script> <script>
if (window.testRunner) { test(() => {
testRunner.dumpAsText(); assert_own_property(window, 'eventSender');
testRunner.waitUntilDone(); eventSender.mouseMoveTo(50,75);
if (window.eventSender) { eventSender.mouseDown();
eventSender.mouseMoveTo(50,75); eventSender.mouseUp();
eventSender.mouseDown(); eventSender.mouseMoveTo(50,0);
eventSender.mouseUp(); eventSender.mouseDown();
eventSender.mouseMoveTo(50,0); eventSender.mouseUp();
eventSender.mouseDown(); eventSender.mouseMoveTo(50,50);
eventSender.mouseUp(); eventSender.mouseDown();
eventSender.mouseMoveTo(50,50); eventSender.mouseUp();
eventSender.mouseDown(); eventSender.mouseMoveTo(50,75);
eventSender.mouseUp(); eventSender.mouseDown();
eventSender.mouseMoveTo(50,75); eventSender.mouseUp();
eventSender.mouseDown(); eventSender.mouseMoveTo(31,108);
eventSender.mouseUp(); eventSender.mouseDown();
eventSender.mouseMoveTo(31,108); eventSender.mouseUp();
eventSender.mouseDown(); eventSender.mouseMoveTo(35,72);
eventSender.mouseUp(); eventSender.mouseDown();
eventSender.mouseMoveTo(35,72); eventSender.mouseUp();
eventSender.mouseDown(); eventSender.mouseMoveTo(31,108);
eventSender.mouseUp(); eventSender.mouseDown();
eventSender.mouseMoveTo(31,108); eventSender.mouseUp();
eventSender.mouseDown(); }, "Should not crash");
eventSender.mouseUp();
}
testRunner.notifyDone();
}
</script> </script>
</body> </body>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment