Commit 1c141bed authored by hendrikw's avatar hendrikw Committed by Commit bot

Revert of [Telemetry] Set the number of attempts to retry a test if browser or...

Revert of [Telemetry] Set the number of attempts to retry a test if browser or tab crash to 1 (patchset #2 id:20001 of https://codereview.chromium.org/659753003/)

Reason for revert:
Possible cause of gpu telemetry bot flake

Original issue's description:
> [Telemetry] Set the number of attempts to retry a test to 1
>
> **SHERIFFS: if telemetry perf tests on waterfall become more flaky, this patch can be safely reverted.
>
> BUG=422339
>
> Committed: https://crrev.com/f5b75f261be7779ccca14d09ddaabb3e4ee5ee03
> Cr-Commit-Position: refs/heads/master@{#299716}

TBR=tonyg@chromium.org,dtu@chromium.org,nednguyen@google.com
NOTREECHECKS=true
NOTRY=true
BUG=422339

Review URL: https://codereview.chromium.org/661303002

Cr-Commit-Position: refs/heads/master@{#300218}
parent 0fed9851
...@@ -188,10 +188,6 @@ class PageRunnerTests(unittest.TestCase): ...@@ -188,10 +188,6 @@ class PageRunnerTests(unittest.TestCase):
self.has_crashed = True self.has_crashed = True
raise exceptions.BrowserGoneException(tab.browser) raise exceptions.BrowserGoneException(tab.browser)
@property
def attempts(self):
return 3
options = options_for_unittests.GetCopy() options = options_for_unittests.GetCopy()
options.output_formats = ['csv'] options.output_formats = ['csv']
options.suppress_gtest_report = True options.suppress_gtest_report = True
......
...@@ -133,7 +133,7 @@ class PageTest(command_line.Command): ...@@ -133,7 +133,7 @@ class PageTest(command_line.Command):
def attempts(self): def attempts(self):
"""Maximum number of times test will be attempted.""" """Maximum number of times test will be attempted."""
# Do NOT override this method (crbug.com/422339). # Do NOT override this method (crbug.com/422339).
return 1 return 3
@property @property
def max_failures(self): def max_failures(self):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment