Commit 1c2c3344 authored by Nnamdi Theodore Johnson-Kanu's avatar Nnamdi Theodore Johnson-Kanu Committed by Chromium LUCI CQ

[CrOS cellular] Add remove profile dialog to internet menu

Bug: 1093185
Change-Id: I33b1825792b33cf0034513bf5ba3932fd5bbf6a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568164
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Reviewed-by: default avatarAzeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833462}
parent 1b1f9164
...@@ -43,7 +43,9 @@ ...@@ -43,7 +43,9 @@
</button> </button>
<hr> <hr>
<button class="dropdown-item" <button class="dropdown-item"
on-click="onRemoveESimProfileTap_"
role="menuitem" role="menuitem"
id="removeBtn"
title="$i18n{networkDetailMenuRemoveESim}"> title="$i18n{networkDetailMenuRemoveESim}">
$i18n{networkDetailMenuRemoveESim} $i18n{networkDetailMenuRemoveESim}
</button> </button>
......
...@@ -96,5 +96,13 @@ Polymer({ ...@@ -96,5 +96,13 @@ Polymer({
*/ */
onRenameESimProfileTap_(e) { onRenameESimProfileTap_(e) {
this.fire('show-esim-profile-rename-dialog', {iccid: this.iccid_}); this.fire('show-esim-profile-rename-dialog', {iccid: this.iccid_});
},
/**
* @param {!Event} e
* @private
*/
onRemoveESimProfileTap_(e) {
this.fire('show-esim-remove-profile-dialog', {iccid: this.iccid_});
} }
}); });
\ No newline at end of file
...@@ -107,4 +107,23 @@ suite('InternetDetailMenu', function() { ...@@ -107,4 +107,23 @@ suite('InternetDetailMenu', function() {
renameBtn.click(); renameBtn.click();
await Promise.all([renameProfilePromise, test_util.flushTasks()]); await Promise.all([renameProfilePromise, test_util.flushTasks()]);
}); });
test('Remove menu button click', async function() {
init();
await flushAsync();
const trippleDot = internetDetailMenu.$$('#moreNetworkDetail');
assertTrue(!!trippleDot);
trippleDot.click();
await flushAsync();
const removeBtn =
internetDetailMenu.shadowRoot.querySelector('cr-action-menu')
.querySelector('#removeBtn');
assertTrue(!!removeBtn);
const removeProfilePromise = test_util.eventToPromise(
'show-esim-remove-profile-dialog', internetDetailMenu);
removeBtn.click();
await Promise.all([removeProfilePromise, test_util.flushTasks()]);
});
}); });
\ No newline at end of file
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment