[CrOS Network] Fix title of settings dialog used to connect to a network.
The <internet-config> element is used in two situations: (1) When attempting a connection to an unconfigured network. In this case, once the user fills in the information needed to configure the network (e.g., Wi-Fi password) and clicks "Connect", a connection is attempted to that network. (2) When attempting to configure a network without connecting. In this case, once a user clicks "Save", the network is configured, but no connection attempt occurs. Currently, the dialog title reads "Configure <networkName>" as long as the network has a name. However, for parity with InternetConfigDialog, the title should read "Join <networkType>" in the first case listed above. This CL accomplishes this goal by piggybacking on top of the "showConnect" property of <internet-config>. Bug: 963841 Change-Id: I542b1adef3edc1e7cbd4c9dea1ebe63c8af2b7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628108 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#662897}
Showing
Please register or sign in to comment