[tools/perf] Add validation that checks for expectations which mix desktop and mobile tags

We should raise exceptions for expectations where the tag condition list mixes mobile and
desktop tags.

Bug: chromium:973936
Change-Id: I52395ead03afb022063bf565f6c1e742cb5f4086
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754982
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689663}

tools/perf/core/story_expectation_validator.py

@@ -7,6 +7,7 @@
 import logging
 import os
 
+
 from core import benchmark_utils
 from core import benchmark_finders
 from core import path_util
@@ -23,6 +24,17 @@ CLUSTER_TELEMETRY_BENCHMARKS = [
     ct_benchmark.Name() for ct_benchmark in
     benchmark_finders.GetBenchmarksInSubDirectory(CLUSTER_TELEMETRY_DIR)
 ]
+MOBILE_PREFIXES = {'android', 'mobile'}
+DESKTOP_PREFIXES = {'chromeos', 'desktop', 'linux', 'mac', 'win'}
+
+
+def is_desktop_tag(tag):
+    return any(tag.lower().startswith(t) for t in DESKTOP_PREFIXES)
+
+
+def is_mobile_tag(tag):
+    return any(tag.lower().startswith(t) for t in MOBILE_PREFIXES)
+
 
 def validate_story_names(benchmarks, test_expectations):
   stories = []
@@ -39,6 +51,21 @@ def validate_story_names(benchmarks, test_expectations):
   assert not unused_patterns, unused_patterns
 
 
+def validate_expectations_component_tags(test_expectations):
+  expectations = []
+  for exps in test_expectations.individual_exps.values():
+    expectations.extend(exps)
+  for exps in test_expectations.glob_exps.values():
+    expectations.extend(exps)
+  for e in expectations:
+    if len(e.tags) > 1:
+      has_mobile_tags = any(is_mobile_tag(t) for t in e.tags)
+      has_desktop_tags = any(is_desktop_tag(t) for t in e.tags)
+      assert not (has_mobile_tags and has_desktop_tags), (
+              ("Expectation on %d is mixing "
+               "mobile and desktop condition tags") % e.lineno)
+
+
 def main():
   benchmarks = benchmark_finders.GetAllBenchmarks()
   with open(path_util.GetExpectationsPath()) as fp:
@@ -49,4 +76,5 @@ def main():
     logging.error(msg)
     return ret
   validate_story_names(benchmarks, test_expectations)
+  validate_expectations_component_tags(test_expectations)
   return 0

tools/perf/core/story_expectation_validator_unittest.py

@@ -65,3 +65,16 @@ class StoryExpectationValidatorTest(unittest.TestCase):
     # all story names are valid. That is why there is no assert here.
     story_expectation_validator.validate_story_names(
         benchmarks, test_expectations)
+
+  def testValidateExpectationsComponentTags(self):
+    raw_expectations = ('# tags: [ android mac ]\n'
+                        '# tags: [ android-webview ]\n'
+                        '# results: [ Skip ]\n'
+                        'crbug.com/123 [ mac android-webview ]'
+                        ' b1/s1 [ Skip ]\n')
+    test_expectations = typ_expectations_parser.TestExpectations()
+    ret, _ = test_expectations.parse_tagged_list(raw_expectations)
+    self.assertFalse(ret)
+    with self.assertRaises(AssertionError):
+      story_expectation_validator.validate_expectations_component_tags(
+          test_expectations)