Commit 1c8a83ec authored by Adam Langley's avatar Adam Langley Committed by Commit Bot

bindings: include wtf_string.h for record members.

Records always have strings as keys, but dictionaries containing records
didn't trigger an include of wtf_string.h automatically. Hasn't been a
problem so far because all such dictionaries have includes other members
that triggered the needed #include.

Change-Id: I882bba80be0d515493261e7fa36759847a211835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245759
Commit-Queue: Adam Langley <agl@chromium.org>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: default avatarHitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778615}
parent b944c280
......@@ -552,6 +552,11 @@ def impl_includes_for_type(idl_type, interfaces_info):
base_idl_type = idl_type.base_type
if idl_type.is_string_type:
includes_for_type.add('platform/wtf/text/wtf_string.h')
if idl_type.is_record_type:
includes_for_type.update(impl_includes_for_type(idl_type.key_type,
interfaces_info))
includes_for_type.update(impl_includes_for_type(idl_type.value_type,
interfaces_info))
if idl_type.is_callback_function:
component = IdlType.callback_functions[base_idl_type]['component_dir']
return set([
......
......@@ -25,7 +25,9 @@
#include "third_party/blink/renderer/bindings/core/v8/v8_treat_non_object_as_null_void_function.h"
#include "third_party/blink/renderer/bindings/core/v8/v8_void_callback_function.h"
#include "third_party/blink/renderer/bindings/tests/idls/core/test_interface_2.h"
#include "third_party/blink/renderer/bindings/tests/idls/core/test_object.h"
#include "third_party/blink/renderer/core/core_export.h"
#include "third_party/blink/renderer/core/dom/element.h"
#include "third_party/blink/renderer/core/typed_arrays/array_buffer_view_helpers.h"
#include "third_party/blink/renderer/core/typed_arrays/dom_typed_array.h"
#include "third_party/blink/renderer/platform/heap/handle.h"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment