Commit 1c99e59a authored by Rakina Zata Amni's avatar Rakina Zata Amni Committed by Commit Bot

Disable proactive BrowsingInstance swap for PopupBlockerSpecialPolicyBrowserTest

The test depends on the fact that unload handlers will run before the
new page renders on same-site navigations, which isn't supported for
same-site cross-RFH navigations currently.

Bug: 977562, 1110744
Change-Id: If191895ec13f9699b478737fa16a7175a9aa3aac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341232Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796016}
parent 9dd1e724
...@@ -501,6 +501,13 @@ IN_PROC_BROWSER_TEST_F(PopupBlockerSpecialPolicyBrowserTest, ...@@ -501,6 +501,13 @@ IN_PROC_BROWSER_TEST_F(PopupBlockerSpecialPolicyBrowserTest,
GURL url( GURL url(
embedded_test_server()->GetURL("/popup_blocker/popup-on-unload.html")); embedded_test_server()->GetURL("/popup_blocker/popup-on-unload.html"));
ui_test_utils::NavigateToURL(browser(), url); ui_test_utils::NavigateToURL(browser(), url);
// Make sure the same-site navigation below will not create a new
// RenderFrameHost, otherwise the unload handler of the old RenderFrameHost
// will run after the new RenderFrameHost gets rendered.
// TODO(crbug.com/1110744): Support running unload handlers before the new
// RenderFrameHost renders on same-site cross-RenderFrameHost navigations.
DisableProactiveBrowsingInstanceSwapFor(
browser()->tab_strip_model()->GetActiveWebContents()->GetMainFrame());
NavigateAndCheckPopupShown(embedded_test_server()->GetURL("/popup_blocker/"), NavigateAndCheckPopupShown(embedded_test_server()->GetURL("/popup_blocker/"),
kExpectPopup); kExpectPopup);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment